1855120 - Pinned tab title change indicator color has changed on Linux with lightweight theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: regression.png

Steps to reproduce:

1. Navigate to https://princefishthrower.github.io/react-use-please-stay/
2. Pin the tab
3. Create a new tab

Actual results:
Indicator color is #3d99ff

Expected results:
Indicator color is #61ffda

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1853188, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Which theme and platform?

Comment 3

[Gregory Pappas [:gregp]]

Which theme

Browser theme: Dark
OS Theme: Adwaita / Adwaita (according to about:support)

and platform?

Fedora Linux

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1855120 - Always use non-native tab attention icon color with lightweight themes. r=dao

Much like with link colors. This restores the behavior on Linux with a
custom theme.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed097fba61cd
Always use non-native tab attention icon color with lightweight themes. r=dao,desktop-theme-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1853188

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ed097fba61cd

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9355005 [details]
Bug 1855120 - Always use non-native tab attention icon color with lightweight themes. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple styling fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9355005 [details]
Bug 1855120 - Always use non-native tab attention icon color with lightweight themes. r=dao

Approved for 119.0b3

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/370b89c128eb

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-09-25 Nightly build on Ubuntu 22, using the Adwaita OS theme, and Dark theme for the browser. Issue is also reproducible on macOS 12 and Windows 10.
Verified as fixed on Firefox 119.0b3(treeherder build, build ID: 20230928191344) and Nightly 120.0a1(build ID: 20230928215127) on Ubuntu 22, macOS 12, Windows 10.