1853188 - Links in the chrome are using the wrong color with a dark theme applied

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Hanna Jones [:hjones]]

Attachment: "Learn more" link before/after

The current link color in the chrome is darker than expected when a dark theme is applied. Previously the color was brighter/more similar to the primary button color (see attached screenshot for a comparison).

Using mozregression points to Bug 1843044.

It looks like prior to that change these styles were getting used to set the link color.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1843044

:emilio, since you are the author of the regressor, bug 1843044, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Where can I see that panel? Now this is using the standard link colors for dark mode.

Comment 3

[Hanna Jones [:hjones]]

Attachment: Screenshot 2023-09-15 at 10.15.24 AM.png

Ah sorry should have provided some STR. That is the ETP panel, which is shown when you click on the shield icon in the URLbar. To get that specific panel view I switched the toggle off, waited for the page to reload, re-opened the panel, then clicked on the "Site fixed? send report" button beneath the toggle. I've provided a screenshot with a bit more context, let me know if that works for you.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1853188 - Use color-scheme and light-dark to manage toolbar / panel colors. r=#desktop-theme-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11fb2a6e4349
Use color-scheme and light-dark to manage toolbar / panel colors. r=desktop-theme-reviewers,dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f962c468736f
Remove leftover urlbar-popup-url-color which causes browser_ext_themes_autocomplete_popup.js to fail.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d645a0d4378
Remove another redundant urlbar-popup-url-color declaration.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/11fb2a6e4349
https://hg.mozilla.org/mozilla-central/rev/f962c468736f
https://hg.mozilla.org/mozilla-central/rev/6d645a0d4378