1855253 - black 23.3.0 reformat reverted unrelated changes

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Julien Cristau [:jcristau]]

I just noticed https://hg.mozilla.org/mozilla-central/rev/e7a99f508f56, which was supposed to be a reformat, has silently backed out changes from at least bug 1849892 and bug 1850749.

Comment 1

[Andrew Halberstadt [:ahal]]

Probably best to revert e7a99f508f56 in case there are other changes it silently backed out.

Comment 2

[Julien Cristau [:jcristau]]

I just went through the diff and as far as I can tell everything but the changes to testing/raptor/raptor/browsertime/base.py and taskcluster/gecko_taskgraph/optimize/strategies.py looks legit.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1786490

:Logan, since you are the author of the regressor, bug 1786490, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Julien Cristau [:jcristau]]

Attachment: Bug 1855253 - Use mozprocess.run_and_wait in raptor r=perftest-reviewers,sparky

[jcristau: restoring changes from bug 1849892 after accidental revert in commit e7a99f508f56]

Comment 5

[Julien Cristau [:jcristau]]

Attachment: Bug 1855253 - remove duplicate index-search optimization method. r=releng-reviewers,taskgraph-reviewers,ahal

index-search is already registered by upstream taskgraph, so this is a
no-op (register_strategy ignores the duplicate registration).

[jcristau: restoring changes from bug 1850749 after accidental revert in changeset e7a99f508f56]

Comment 6

[Julien Cristau [:jcristau]]

Attachment: Bug 1855253 - use upstream taskgraph's skip-unless-changed optimization. r=releng-reviewers,taskgraph-reviewers,ahal

As far as I can tell the only difference is that upstream checks the
repository_type param before considering pushlog id.

[jcristau: restoring changes from bug 1850749 after accidental revert in changeset e7a99f508f56]

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4598c403131f
Use mozprocess.run_and_wait in raptor r=sparky,perftest-reviewers
https://hg.mozilla.org/integration/autoland/rev/609dcce0f19d
remove duplicate index-search optimization method.
https://hg.mozilla.org/integration/autoland/rev/a2f48c396ce4
use upstream taskgraph's skip-unless-changed optimization.

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4598c403131f
https://hg.mozilla.org/mozilla-central/rev/609dcce0f19d
https://hg.mozilla.org/mozilla-central/rev/a2f48c396ce4