1850749 - de-duplicate index-search and skip-unless-changed optimizations

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Julien Cristau [:jcristau]]

Bug 1780278 merged optimization logic between taskgraph and gecko_taskgraph, but we're still duplicating the index-search and skip-unless-changed optimizations.

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1850749 - remove duplicate index-search optimization method. r?#releng

index-search is already registered by upstream taskgraph, so this is a
no-op (register_strategy ignores the duplicate registration).

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1850749 - use upstream taskgraph's skip-unless-changed optimization. r?#releng

As far as I can tell the only difference is that upstream checks the
repository_type param before considering pushlog id.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/878c11c82fc5
remove duplicate index-search optimization method. r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/2e446d8859cc
use upstream taskgraph's skip-unless-changed optimization. r=releng-reviewers,taskgraph-reviewers,ahal

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/878c11c82fc5
https://hg.mozilla.org/mozilla-central/rev/2e446d8859cc

Comment 5

[Nicklas Boman [:smurfd]]

Hey, sorry for commenting on a closed bug, i noticed that after this patch was applied, i no longer get the artifacts downloaded (on mac), even after i clear $HOME/.mozbuild
usually when you mach bootstrap you get something like:

Downloading artifact to local cache: /Users/smurfd/.mozbuild/toolchains/92cb56d28216ec86-clang.tar.zst

this does not happen after this. was that the plan?

changeset:   676648:1f709b0dc718 (bootstrap does not work)
summary:     Bug 1850904 - Expand media.allow-audio-non-utility to early beta r=alwu

changeset:   676647:2e446d8859cc
summary:     Bug 1850749 - use upstream taskgraph's skip-unless-changed optimization. r=releng-reviewers,taskgraph-reviewers,ahal

changeset:   676646:878c11c82fc5
summary:     Bug 1850749 - remove duplicate index-search optimization method. r=releng-reviewers,taskgraph-reviewers,ahal

changeset:   676645:d06fb43a32e5 (bootstrap works)
summary:     Bug 1845159 - Add preferences pane checkbox for clipboard suggestion. r=mak,fluent-reviewers,settings-reviewers

Comment 6

[Ryan VanderMeulen (PTO, back July 27)]

I'm seeing the same on Windows. This seems to have broken bootstrapping during configure.

Comment 7

[Julien Cristau [:jcristau]]

Attachment: Bug 1850749 - update references to IndexSearch. r?#releng

Fixes mach bootstrap, among others.

Comment 8

[Julien Cristau [:jcristau]]

Sorry about that; fix is up in comment 7.

Comment 9

[Phabricator Automation]

Comment on attachment 9351407 [details]
Bug 1850749 - update references to IndexSearch. r?#releng

Revision D187361 was moved to bug 1851405. Setting attachment 9351407 [details] to obsolete.