1855527 - Failures in dom/base/test/fullscreen/test_fullscreen_modal.html in M-xorig

Status: RESOLVED DUPLICATE of bug 1855530

(GeckoView Graveyard :: Sandboxing, defect, P2)

Description

[[:owlish] 🦉 PST]

This test fails on all Android builds with both isolateEverything and isolateHighValue isolation strategies (fission.webContentIsolationStrategy set to 1 or 2 respectively). The failures are different for different isolation strategies.

isolateHighValue-specific failure:

[task 2023-09-25T23:58:47.154Z] 23:58:47  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/fullscreen/test_fullscreen_modal.html | Should've been able to click - didn't expect 1, but got it
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      SimpleTest.isnot@SimpleTest/SimpleTest.js:528:14
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      clickButton@dom/base/test/fullscreen/test_fullscreen_modal.html?currentTestURL=dom%2Fbase%2Ftest%2Ffullscreen%2Ftest_fullscreen_modal.html&closeWhenDone=1&showTestReport=false&expected=pass:38:29
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      testFullscreenIsModal@dom/base/test/fullscreen/test_fullscreen_modal.html?currentTestURL=dom%2Fbase%2Ftest%2Ffullscreen%2Ftest_fullscreen_modal.html&closeWhenDone=1&showTestReport=false&expected=pass:62:14
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      async*@dom/base/test/fullscreen/test_fullscreen_modal.html?currentTestURL=dom%2Fbase%2Ftest%2Ffullscreen%2Ftest_fullscreen_modal.html&closeWhenDone=1&showTestReport=false&expected=pass:66:9
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      nextTick/<@SimpleTest/SimpleTest.js:2189:34
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      nextTick@SimpleTest/SimpleTest.js:2233:11
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:922:41
[task 2023-09-25T23:58:47.154Z] 23:58:47     INFO -      add_task@SimpleTest/SimpleTest.js:2137:17
[task 2023-09-25T23:58:47.155Z] 23:58:47     INFO -      @dom/base/test/fullscreen/test_fullscreen_modal.html?currentTestURL=dom%2Fbase%2Ftest%2Ffullscreen%2Ftest_fullscreen_modal.html&closeWhenDone=1&showTestReport=false&expected=pass:65:9

example try push
logcat from that try push

---

isolateEverything-specific failures:

[task 2023-09-25T23:57:12.898Z] 23:57:12  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/fullscreen/test_fullscreen_modal.html | Test timed out. -
[task 2023-09-25T23:57:12.898Z] 23:57:12  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/fullscreen/test_fullscreen_modal.html | TypeError: Fullscreen request aborted - Should not throw any errors
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -      nextTick/<@SimpleTest/SimpleTest.js:2216:26
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -      async*nextTick@SimpleTest/SimpleTest.js:2233:11
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:922:41
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -      add_task@SimpleTest/SimpleTest.js:2137:17
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -      @dom/base/test/fullscreen/test_fullscreen_modal.html?currentTestURL=dom%2Fbase%2Ftest%2Ffullscreen%2Ftest_fullscreen_modal.html&closeWhenDone=1&showTestReport=false&expected=pass:65:9
[task 2023-09-25T23:57:12.898Z] 23:57:12  WARNING -  TEST-UNEXPECTED-FAIL | SimpleTest | this test already called finish!
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -  addAssertionCount should only be called by a cross origin test
[task 2023-09-25T23:57:12.898Z] 23:57:12  WARNING -  TEST-UNEXPECTED-ERROR | dom/base/test/fullscreen/test_fullscreen_modal.html | called finish() multiple times
[task 2023-09-25T23:57:12.898Z] 23:57:12     INFO -  TEST-INFO took 320425ms

example try push
logcat from that try push

Comment 1

[[:owlish] 🦉 PST]

Hey Emilio, would you help us out here please? I see your name in the git log for this test

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So this seems like a deeper / more general problem with fullscreen on Android right? The other fullscreen tests are also failing. Regarding the last failure, it seems the fullscreen request gets aborted. Probably around here. Would be good to know what switches focus to another window or what not.

Do you know how to run those locally / see stack traces / etc? On Linux I'd do MozWalkTheStack(stderr) around here.

Might also be worth seeing if the test passes with this pref set to false.

Comment 3

[[:owlish] 🦉 PST]

Hi Emilio, thank you for looking! To run these locally, you need to build Android and then you run these as usual, the flag --disable-fission disables Fission (the tests run with Fission by default). To see the logcat, if you don't have Android Studio, open a separate terminal window and run adb logcat - it will start printing the logcat from the emulator. To have MOZLOG in the logcat, add CreateOrGetModule("modulename")->SetLevel(LogLevel::Verbose); to this spot. As for MozWalkTheStack(stderr) - I'm not sure if that will work, I never heard of it before. Seems worth trying.