1855530 - Timeout in dom/base/test/test_lock_orientation_with_pending_fullscreen.html in M-xorig

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect, P2)

Description

[[:owlish] 🦉 PST]

This test fails on all Android builds with isolateEverything isolation strategy (fission.webContentIsolationStrategy set to 1, or default).

Failure:

[task 2023-09-26T00:10:00.481Z] 00:10:00  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/test_lock_orientation_after_fullscreen.html | Test timed out. -
[task 2023-09-26T00:10:00.481Z] 00:10:00  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/test_lock_orientation_after_fullscreen.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2023-09-26T00:10:00.481Z] 00:10:00     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2023-09-26T00:10:00.481Z] 00:10:00     INFO -      afterCleanup@SimpleTest/SimpleTest.js:1477:18
[task 2023-09-26T00:10:00.481Z] 00:10:00     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1562:7
[task 2023-09-26T00:10:00.481Z] 00:10:00     INFO -      SimpleTest.finish@SimpleTest/SimpleTest.js:1582:3
[task 2023-09-26T00:10:00.481Z] 00:10:00     INFO -      @SimpleTest/SimpleTest.js:2265:16
[task 2023-09-26T00:10:00.482Z] 00:10:00     INFO -      async*@SimpleTest/SimpleTest.js:2262:17

example try push
logcat from that try push

Comment 1

[[:owlish] 🦉 PST]

Hey Makoto, you seem to be the author of the test, and the most familiar with it - do you have ideas on what might be going on here?

Comment 2

[Makoto Kato [:m_kato]]

I will look it why.

Comment 3

[Makoto Kato [:m_kato]]

It seems not work fullscreen listener in screen orientation (for YouTube's workaround).

Comment 4

[Makoto Kato [:m_kato]]

When turning on screen orientation on desktop at force (removing hard coded condition etc), tests are passed. I guess that this issue is a kind of full screen handling in GV.

Comment 5

[Makoto Kato [:m_kato]]

(I guess that root cause might be same as bug 1855865)

Comment 6

[Makoto Kato [:m_kato]]

Actually we sent DOMFullscreen event via sendToAllChildren. But this isn't Fission compatible. Desktop stores parent actor on DOMFullscreen:Request, then use it.

Comment 7

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e8fc4a1a91d4439d6ef725e6a7d0721537eacfe2

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Bug 1855530 - Use origin actor to send DOMFullscreen message. r=#geckoview-reviewers

Actually, we use GeckoViewContent.sendToAllChildren to send full screen
message to child.

According to bug 1505916, we should use request origin actor instead.

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Bug 1855530 - Part 2. Move Full screen code from GeckoViewContentChild to ContentDelegateChild. r=#geckoview-reviewers

Actually, we are handling fullscreen API in both GeckoViewContentParent/Child
and ContentDelegateChild. To enter full screen, application has to set
ContentDelegate then handle ContentDelegate.onFullScreen.

I think no reason to split fullscreen code into both actors.

So, to make simple, I would like to move all full screen code in
GeckoViewContentChild to ContentDelegateChild.

Depends on D193610

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0083ca2f4709
Use origin actor to send DOMFullscreen message. r=geckoview-reviewers,owlish

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0083ca2f4709

Comment 16

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #10)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0083ca2f4709
Use origin actor to send DOMFullscreen message. r=geckoview-reviewers,owlish

== Change summary for alert #40311 (as of Tue, 21 Nov 2023 11:33:30 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
8%	instagram FirstVisualChange	linux1804-64-shippable-qr	cold fission webrender	284.37 -> 260.72	Before/After
6%	instagram fcp	linux1804-64-shippable-qr	cold fission webrender	257.30 -> 241.52	Before/After
5%	instagram fcp	linux1804-64-shippable-qr	cold fission webrender	254.99 -> 241.07
2%	instagram loadtime	linux1804-64-shippable-qr	cold fission webrender	1,972.40 -> 1,925.94	Before/After
2%	instagram PerceptualSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	802.68 -> 783.92	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40311