1855561 - Star rating for `recommended-ad` should use `--icon-color`

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P2)

Description

[kpatenio]

Attachment: different-star-rating-background-color.png

Bug 1851855 updates icon background color to use --icon-color except for the star rating for the recommendations component. Let's be sure the colors are consistent.

Comment 1

[Amy Churchwell [:amy]]

Attachment: Bug 1855561 - update star rating widget to use icon-color as fill. r=#shopping-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f111d9b9295a
update star rating widget to use icon-color as fill. r=shopping-reviewers,reusable-components-reviewers,Gijs,hjones

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f111d9b9295a

Comment 4

[Amy Churchwell [:amy]]

Comment on attachment 9355918 [details]
Bug 1855561 - update star rating widget to use icon-color as fill. r=#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Minimal, this patch adds color uniformity to the star rating icons.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The shopping experiment is limited to a very small audience in 119. This patch is a small visual change on the star rating icons.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9355918 [details]
Bug 1855561 - update star rating widget to use icon-color as fill. r=#shopping-reviewers

Approved for 119.0b6

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a93b2a34c1b5

Comment 7

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta 119.0b6 and our latest Nightly build 120.0a1 (2023-10-08).

Comment 8

[Amy Churchwell [:amy]]

The fix for this bug incidentally includes a fix for bug 1856031 also, writing for posterity.