1855594 - Use different profiler settings for MotionMark

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Markus Stange [:mstange]]

We automatically gather profiles from MotionMark in CI, e.g. on this job (corresponding profile)

Since this is a test that mostly exercises graphics code, we should change the profiler settings to match those of the "Graphics" preset.

The profile linked above does not have the threads I was looking for (CanvasWorkers in this case). It is also very large because of the included screenshots. Adjusting the features to match the Graphics preset would solve both problems.

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

from a quick look, getting this implemented should help with Bug 1853434 slightly
does not look like gecko_profiler_* configs are properly parsed by the manifest parsing script when --extra-profiler-run is used

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1855594 - Use "Graphics" profiler preset settings for MotionMark benchmarks r?sparky,kshampur,#perftest

MotionMark benchmark exercises graphics code. That's why it's important to see
graphics related threads when we are looking at a MotionMark profile. This
patch changes the profiler features and threads to match the "Graphics" preset
that we have in the profiler popup:
https://searchfox.org/mozilla-central/rev/a2709c2f0e31b2ad1a7b6447117626a34063fe57/devtools/client/performance-new/shared/background.jsm.js#163-177

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/303334fc1459
Use "Graphics" profiler preset settings for MotionMark benchmarks r=kshampur,perftest-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/303334fc1459