1855643 - Unable to undo deletion of an email / message deleted in standalone message window

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Dwarf]

Steps to reproduce:

Open email (or rss feed message) in new-window mode
Delete said message/email
Realise didnt mean to delete the message, and go to UNDO the deletion - to find the option greyed out, and ctl-z also does nothing

Note that opening a message in new-tab mode DOES allow UNDO of deletion of the message

Actual results:

The option to UNDO deletion of a message (when opened in new-window mode) is unavailable

Expected results:

The option to UNDO deletion a message (when opened in new-window mode) should be available (as it is in new-tab mode AND as it was for new-window mode in tbird 102

Comment 1

[Magnus Melin [:mkmelin]]

Well since you deleted the message, you moved to the next message, right?

Comment 2

[Dwarf]

Yes
And? so what?
the same thing "since you deleted the message, you moved to the next message" applies in view-as-new-tab mode
AND applied in v102
And yet in BOTH those instances, the undo-deleted-message was/is still available when deleting a viewed/opened message

Comment 3

[betterbird.project+10]

Quite a view bits missing to get this to work again:
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1855643-fix-undo-redo-stand-alone.patch

Comment 4

[Wayne Mery (:wsmwk)]

I have mixed results with standalone window:

• undo works for me on windows 10 with 115.5.0
• undo fails for me on Mac with 120.0b6

Comment 5

[Calum Mackay]

yup, confirmed on Mac Daily 122.0a1, too.

"Edit -> Undo Delete Message" is offered when the message is deleted from a new tab, but not when deleted from a new window.

Comment 6

[Silvia Bonavista i Serrat]

Attachment: Bug 1855643 - Fix undo/redo menu activation for stand-alone window. r=mkmelin

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1855643-fix-undo-redo-stand-alone.patch

Depends on D204153

Comment 7

[Silvia Bonavista i Serrat]

Attachment: Bug 1855643 - Fix undo/redo menu activation for stand-alone window. r=mkmelin

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1855643-fix-undo-redo-stand-alone.patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a5a9210fed2d
Fix undo/redo menu activation for stand-alone window. r=mkmelin

Comment 9

[Magnus Melin [:mkmelin]]

This is breaking comm/mail/components/extensions/test/browser/browser_ext_messages_open_attachment.js

JavaScript error: chrome://messenger/content/messageWindow.js, line 626: TypeError: can't access property "transactionManager", mainWindow.msgWindow is undefined
 [JavaScript Error: "TypeError: can't access property "transactionManager", mainWindow.msgWindow is undefined" {file: "chrome://messenger/content/messageWindow.js" line: 626}]
SetupCommandUpdateHandlers@chrome://messenger/content/messageWindow.js:626:1
delayedOnLoadMessageWindow@chrome://messenger/content/messageWindow.js:132:3
setTimeout handler*OnLoadMessageWindow@chrome://messenger/content/messageWindow.js:91:13
EventListener.handleEvent*@chrome://messenger/content/messageWindow.js:60:8

Comment 10

[Magnus Melin [:mkmelin]]

Backout: https://hg.mozilla.org/comm-central/rev/94880217c72cc2c8b470c54a4aa188a2365cc581

Comment 11

[Silvia Bonavista i Serrat]

Updated the patch in Phab. Sorry about the test failure.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/25090fdc2682
Fix undo/redo menu activation for stand-alone window. r=mkmelin,freaktechnik