1855676 - Consider adding some padding between the settings chevron and show ads button slider in the review checker sidebar

Status: RESOLVED WORKSFORME

(Firefox :: Shopping, enhancement, P2)

Description

[Peter Magyari (Desktop QA)]

Attachment: addsbutton-chevron-gap.png

Found in

• Nightly 120.0a1 (2023-09-28)

Affected versions

• 119.0b1 (2023-09-25)
• 120.0a1 (2023-09-28)

Affected platforms

• Windows 10 / MacOS 11 / Ubuntu 20.04

Preconditions

• browser.shopping.experience2023.enabled: true
• browser.shopping.experience2023.optedIn: 1
• browser.shopping.experience2023.ads.enabled: true
• browser.shopping.experience2023.ads.userEnabled: true

Steps to reproduce

1. Open a random amazon product page.
2. Click on the Chevronfrom the Settings card inside the review checker sidebar in order to expand it.

Expected result

• Settings card is expanded, the spacing between the elements is suitable.

Actual result

• There isn't enough space between the chevron and the "show ads..." button slider.

Regression

• This is not a regression.

Comment 1

[Anna Yeddi [:ayeddi]]

These touch targets are below WCAG recommendations and the lack of padding between them would make it difficult to use for users with limited dexterity as well as it may introduce overlaps in active areas for alternative input controls like switches and other assistive technology, thus marking it up as access-s2

Comment 2

[Ania]

This will not affect users in 119 (since no one externally can see ads or ads toggle), but it's a high-priority item for 120. I'm going to remove the 119-affected flag if it's ok.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jhirsch, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: macos-screenshot-120.0a1-2023-10-06.png

The spacing looks fine for me on 120.0a1 (2023-10-06) (64-bit) MacOS. Was this fixed since it was filed?

Comment 5

[:Gijs (he/him)]

I think this might have been fixed in bug 1856060 but I'll doublecheck.

Comment 6

[Peter Magyari (Desktop QA)]

It looks like this has indeed been fixed by Bug 1856060.
I'll go ahead and close this issue.
Thanks!

Comment 7

[:Gijs (he/him)]

Thanks, sorry, didn't find the time to confirm via mozregression --find-fix or similar yet. But yes, I recall noticing that the padding in the settings pane was relying on the ads setting being there (and now that ads can be disabled entirely that setting isn't there and so the padding was off) and that's been resolved.