1855685 - Inline preview bookmarks are treated as regular source code tokens

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2023-09-28 at 12.11.16.png

See screenshot

mozregression gave me this range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e5cda9112336dc953a11c0cd0403690ca54ba077&tochange=2ea4fd5d517a2b5edf081c9e2ccd8c014f6dc171 , so the regression might be from Bug 1851522 too (but Bug 1851566 did modified the preview action, so it's more likely)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1851566

:ochameau, since you are the author of the regressor, bug 1851566, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dianna Smith [:diannaS]]

:Nicolas do you think you can identify the priority/severity for this?

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1855685 - [devtools] Avoid showing preview tooltips when hovering over inline previews r=#devtools-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a42db02e53a4
[devtools] Avoid showing preview tooltips when hovering over inline previews r=devtools-reviewers,nchevobbe

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a42db02e53a4

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9356595 [details]
Bug 1855685 - [devtools] Avoid showing preview tooltips when hovering over inline previews r=#devtools-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Weird UI issue when hovering element in the Debugger editor
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small devtools change, covered by test
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9356595 [details]
Bug 1855685 - [devtools] Avoid showing preview tooltips when hovering over inline previews r=#devtools-reviewers

Approved for 119.0 RC1

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/11d1909ae147