Closed
Bug 1855768
Opened 2 years ago
Closed 2 years ago
Highlights component updates to support DE/FR
Categories
(Firefox Graveyard :: Shopping, task, P2)
Firefox Graveyard
Shopping
Tracking
(firefox122 fixed)
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: jhirsch, Assigned: kpatenio)
References
Details
Attachments
(1 file)
The highlights component currently uses American-style quotation marks to enclose review highlights. We should consider using localized punctuation here instead.
Very minor additional issue: we currently explicitly set the language attribute lang to "en" when creating highlights, and we'll want to update that, too. See https://searchfox.org/mozilla-central/rev/6b91b922725838e2732aeb478b13e5b33e33ce1b/browser/components/shopping/content/highlights.mjs#89-91
|
||
Updated•2 years ago
|
Severity: -- → S2
Priority: -- → P2
Just got confirmation from Rob and Will that the highlights will only be in French for .fr and German for .de. Introducing English into the highlights model for FR/DE is a complex effort and requires more resources than we can afford at this time.
|
||
Updated•2 years ago
|
Attachment #9365682 -
Attachment description: WIP: Bug 1855768 - add de and fr lang property support for review checker highlights. r=#shopping-reviewers! → Bug 1855768 - add de and fr lang property support for review checker highlights. r=#shopping-reviewers!
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4790c92a5a4f
add de and fr lang property support for review checker highlights. r=shopping-reviewers,Gijs
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
|
||
Updated•8 months ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•