1855810 - Implement telemetry event for shopping ad impressions

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, task, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Implement the shoppingSurfaceTrustedDealImpression probe as described in https://docs.google.com/spreadsheets/d/1IVDm72fXuUsXV_h9fpNJ4y8VfAl2r334Hm7c1Shm1Gc/edit#gid=818994546

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1855810 - Implement telemetry event for shopping ad impressions. r?perry.mcmanis

Depends on D190958

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9358363 [details]
Bug 1855810 - Implement telemetry event for shopping ad impressions. r?perry.mcmanis

DATA REVIEW REQUEST

1. What questions will you answer with this data?

How often are ads shown in the sidebar long enough (1.5 seconds) to count as an impression? For users who see ads, what else happens? Does displaying ads result in users not using the feature? Not using Firefox?

2. Why does Mozilla need to answer these questions? Are there benefits for users?
   Do we need this information to address product or business requirements?

Business wants to show ads here, but also wants to understand potential impacts on feature retention and Firefox user retention.

3. What alternative methods did you consider to answer these questions?
   Why were they not sufficient?

This is the least invasive way of answering these questions--we don't track which ad is shown, just that an ad was shown.

4. Can current instrumentation answer these questions?

No.

5. List all proposed measurements and indicate the category of data collection for each
   measurement, using the Firefox data collection categories found on the Mozilla wiki.

Measurement Name	Measurement Description	Data Collection Category	Tracking Bug
shopping.surface_ads_impression	An ad was shown and visible in the sidebar for 1.5 seconds.	interaction	https://bugzilla.mozilla.org/show_bug.cgi?id=1855810

6. Please provide a link to the documentation for this data collection which
   describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented in the Glean Dictionary.

7. How long will this data be collected?

This collection has expiry '122'.

8. What populations will you measure?

All channels, countries, and locales. No filters.

9. If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the product's preferences.

10. Please provide a general description of how you will analyze this data.

Data Science will create dashboards.

11. Where do you intend to share the results of your analysis?

Internally.

12. Is there a third-party tool (i.e. not Glean or Telemetry) that you
    are proposing to use for this data collection?

No.

Comment 3

[Travis Long [:travis_]]

Comment on attachment 9358363 [details]
Bug 1855810 - Implement telemetry event for shopping ad impressions. r?perry.mcmanis

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection to end or be renewed by version 122

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b855c71dfc07
Implement telemetry event for shopping ad impressions. r=perry.mcmanis

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b855c71dfc07

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 120.0b2 on Windows 11x64, macOS 12 and Ubuntu 18.04. The surface_ads_impression event is displayed Glean after opening a product containing an ad inside the sidebar.