1855827 - Sub-menu gets cut off when the browser window isn't wide enough

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2023-09-28 at 4.08.16 PM.png

Steps to reproduce:

1. Go to "Open tabs" in "Recent Browsing" in Firefox View (Nightly)
2. Click on … next to a URL
3. Go to "Move Tab"

Expected:
Menu is fully visible

Actual:
Menu is cut off when the window is not wide enough

Comment 1

[Sarah Clements [:sclements]]

Gonna mark this as S3 since the workaround is to make the screen narrower (or wider). This only happens at a specific breakpoint. But I'll try to get a fix in for 119.

Comment 2

[Sarah Clements [:sclements]]

Attachment: Bug 1855827 - Fix submenu alignment r=mstriemer

• Change setSubmenuAlign to take into account submenu panel width and parent panel width when setting alignment

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c52b46de616f
Fix submenu alignment r=reusable-components-reviewers,hjones

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c52b46de616f

Comment 5

[Sarah Clements [:sclements]]

Comment on attachment 9356212 [details]
Bug 1855827 - Fix submenu alignment r=mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: Per the screenshot in the bug, at a certain breakpoint submenu items in Firefox View will be cut off and not easily accessible. The submenu panel has general functionality covered in tests, but this particular alignment change is not covered by tests.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See the first comment in the bug, as this is easily reproducible at about 1735px wide screen.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only affects alignment for the submenu panel, which is currently only used in Firefox View.
• String changes made/needed: No
• Is Android affected?: No

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9356212 [details]
Bug 1855827 - Fix submenu alignment r=mstriemer

Approved for 119.0b6

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4f4e70e59d5c

Comment 8

[Bogdan Maris, Desktop QA]

Attachment: Overlap menu

I reproduced the initial issue reported here using an old Nightly build from 2023-09-28. I verified that this is now fixed using latest Nightly 120.0a1 build and Firefox Beta 190.0b5 on MacOS 13.6 and Ubuntu 22.04.

On Windows 10 though I can still reproduce this at a particular resolution (about 1878px, the measurement was not that precise so a few pixels might be off) the menu will be cut off, not as bad as before but it still gets cut off. The only thing needed is having 2-3 websites opened and not only the New Tab. I've attached a Gif on that. I also checked on the Nightly build when the patch landed and the behavior is the same there.
Do you want to reopen this bug or log a new one?

Comment 9

[Sarah Clements [:sclements]]

(In reply to Bogdan Maris, Desktop QA from comment #8)

Created attachment 9357010 [details]
Overlap menu

I reproduced the initial issue reported here using an old Nightly build from 2023-09-28. I verified that this is now fixed using latest Nightly 120.0a1 build and Firefox Beta 190.0b5 on MacOS 13.6 and Ubuntu 22.04.

On Windows 10 though I can still reproduce this at a particular resolution (about 1878px, the measurement was not that precise so a few pixels might be off) the menu will be cut off, not as bad as before but it still gets cut off. The only thing needed is having 2-3 websites opened and not only the New Tab. I've attached a Gif on that. I also checked on the Nightly build when the patch landed and the behavior is the same there.
Do you want to reopen this bug or log a new one?

Thanks for catching that. I agree its not as bad (and at least its only on Windows 10). Can you still access the submenu items with the mouse?

If you can file a new bug for it I'll get it fixed asap.

Comment 10

[Bogdan Maris, Desktop QA]

(In reply to Sarah Clements [:sclements] from comment #9)

(In reply to Bogdan Maris, Desktop QA from comment #8)

Created attachment 9357010 [details]
Overlap menu

I reproduced the initial issue reported here using an old Nightly build from 2023-09-28. I verified that this is now fixed using latest Nightly 120.0a1 build and Firefox Beta 190.0b5 on MacOS 13.6 and Ubuntu 22.04.

On Windows 10 though I can still reproduce this at a particular resolution (about 1878px, the measurement was not that precise so a few pixels might be off) the menu will be cut off, not as bad as before but it still gets cut off. The only thing needed is having 2-3 websites opened and not only the New Tab. I've attached a Gif on that. I also checked on the Nightly build when the patch landed and the behavior is the same there.
Do you want to reopen this bug or log a new one?

Thanks for catching that. I agree its not as bad (and at least its only on Windows 10). Can you still access the submenu items with the mouse?

If you can file a new bug for it I'll get it fixed asap.

Yep, the menus can be accessible, if I shrink the width of the page more the submenu will jump to the other side. I filled bug 1857511 for the remaining issue. Will come back and close this one once bug 1857511 will get fixed and verified.

Comment 11

[Bogdan Maris, Desktop QA]

Since I also verified that the fix from bug 1857511 did not break anything in Fx120 I will also go ahead and mark this as verified in 120.

Comment 13

[Bogdan Maris, Desktop QA]

(In reply to Bogdan Maris, Desktop QA from comment #11)

Since I also verified that the fix from bug 1857511 did not break anything in Fx120 I will also go ahead and mark this as verified in 120.

I'll also mark it verified fixed for Fx119 based on the testing I've done here, since Fx119 from bug 1857511 has been marked as wontfix and the fix will be left to ride the trains of Fx120.