1857511 - [Windows] Sub-menu gets cut off when the browser window isn't wide enough

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the issue

This bug is an addition to the fix from bug 1855827.

Affected versions

• Firefox Beta 119.0b5
• Latest Nightly 120.0a1

Tested platforms

• Affected platforms: Windows 10 (probably Windows 11 as well)
• Unaffected platforms: MacOS 13 and Ubuntu 22.04

Preconditions

• None

Steps to reproduce

1. Open Firefox and make it wide enough (1878px for example)
2. Visit 1 or 2 websites
3. Open Firefox View
4. Click on ... button next to a URL
5. Go to "Move Tab" with the cursor of the mouse

Expected result

• Submenu if fully visible on the left side or the left side.

Actual result

• Submenu is cut off by the scrollbar at the edge of the window.

Regression range

• Not a regression, is an addition to bug 1855827.

Additional notes

• Gif showing the issue is attached.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:bmaris, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Sarah Clements [:sclements]]

Thanks Bogdan.

Comment 3

[Sarah Clements [:sclements]]

Attachment: Bug 1857511 - Modify submenu alignment in panelList r=#reusable-components-reviewers

• Swap out winWidth for scrollingElement.clientWidth to account for vertical scrollbar width

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/361e571454e9
Modify submenu alignment in panelList r=reusable-components-reviewers,hjones

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/361e571454e9

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Looks fixed to me using latest Nightly 120.0a1 (https://treeherder.mozilla.org/jobs?repo=mozilla-central&selectedTaskRun=Y9M-d_p9T56GzTiaJnMtig.0) on Windows 10.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sclements, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.