1855843 - Conversations' users can't convert a message to an event or task

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Mark Banner (:standard8)]

STR

1. Install the Conversations add-on.
2. Select a message
3. Right-click the message and select "Convert To" -> "Event" (or "Task").

Expected Results

A new window is opened for a new event or task as selected.

Actual Results

Nothing happens.

The issue is that extractFromEmail assume that it knows what is happening with the message display and assumes that the normal display mechanisms exist.

For Conversations, that isn't true, since Conversations uses the multi-message pane browser.

Given that these are context menu items, we should primarily be using the message that's actually selected in the message list (although it doesn't matter too much in this case, it is better overall, and would allow Convert To in the context menu to work when right-clicking on non-selected messages).

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1855843 - Allow message conversion to event or a task work with the message selected in the message list. r?#thunderbird-reviewers!

Using the selected message in the message list is more reliable, especially as this is a context menu event.
Unfortuantely, we have to take account of other cases as well, and the message selection.

Comment 2

[M Lopez-Ibanez]

Is this ready to commit?

Comment 3

[M Lopez-Ibanez]

Sorry, I see now that the discussion is ongoing in phabricator. Apologies for the added noise.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f95b32bb164
Allow message conversion to event or a task work with the message selected in the message list. r=freaktechnik

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9355714 [details]
Bug 1855843 - Allow message conversion to event or a task work with the message selected in the message list. r?#thunderbird-reviewers!

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: users of Thunderbird conversations can't use convert to event/task
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): fairly safe

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9355714 [details]
Bug 1855843 - Allow message conversion to event or a task work with the message selected in the message list. r?#thunderbird-reviewers!

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/fd557e7c9f82

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9355714 [details]
Bug 1855843 - Allow message conversion to event or a task work with the message selected in the message list. r?#thunderbird-reviewers!

[Triage Comment]
Approved for esr115

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 115.3.3:
https://hg.mozilla.org/releases/comm-esr115/rev/e1ce2f9fb77f