1855974 - The Unsupported product error message is not displayed for unsupported products in the Shopping sidebar

Status: RESOLVED FIXED

(Firefox :: Shopping, defect)

Description

[Rares Doghi, Desktop QA]

Found in

• Beta 119.0b1

Affected versions

• Beta 119.0b1
• Nightly 120.0a1 (2023-09-29)

Affected platforms

• All

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1

Steps to reproduce

1. Reach the following links:
   BestBuy gift card: https://www.bestbuy.com/site/best-buy-50-best-buy-gift-card-with-gift-box/6349639.p?skuId=6349639
   VideoGames: https://www.amazon.com/luna/detail/B0C3QB7QKV
   Amazon music: https://www.amazon.com/dp/B0C1Q4GWXJ/
2. Open the Sidebar.

Expected result

• The Unsupported product error message should be displayed for these products.

Actual result

• In some cases the Check review quality card is displayed again in infinite loop, while in other cases the error message is not displayed instead the reviews are being displayed.

Regression range
Not Applicable

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1855974 - Use Shopping Status API status as data or errors. r=#shopping-reviewers

• Throws errors when we get an response that there was an issue from the Shopping Status and Analyze APIs.
• Updates the ShoppingContainer to handle error states that have non-generic messages to show.

Comment 2

[Ania]

This should hopefully get fixed on Monday when server starts returning a correct flag for these products - https://mozilla-hub.atlassian.net/browse/FAK-501

Let's please reverify it on Tuesday to make sure that unsupported products act as expected and return a correct error when attempting to analyze them
Here's an example of a product where we receive the flag correctly - https://www.amazon.com/Amazon-com-Greeting-Birthday-Birds-Design/dp/B0773DDXGL/?th=1

Comment 3

[Ania]

Ok, so the correct dependency here is this server-side ticket - https://mozilla-hub.atlassian.net/browse/FAK-570.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/277291259820
Use Shopping Status API status as data or errors. r=shopping-reviewers,Gijs

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/277291259820

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:fchasen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Rares Doghi, Desktop QA]

Hi @fchasen, it seems that for the https://www.bestbuy.com/site/best-buy-50-best-buy-gift-card-with-gift-box/6349639.p?skuId=6349639 product we still see the reviews instead of the Unsupported message can you please take a look ?

Comment 8

[Fred Chasen [:fchasen]]

Thanks @rares.doghi, unfortunately we are dependent on the Fakespot API to mark products as unsupported.

Maybe we can come up with a way to file bugs with them for specific products that aren't working correctly? Slack seems to work ok for now though.

Comment 9

[rgross]

@rares.doghi and @fchasen: Fakespot is working on fixing this bug.

Comment 10

[Rares Doghi, Desktop QA]

Marking this issue Verified as fixed since the issue with the gift cards is being fixed on the Server side by the Fakespot team.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Is this working for 120 as well then?

Comment 12

[Rares Doghi, Desktop QA]

Yes, the issue seems to be fixed in 120.0b7. Should we update the Flag from affected to Verified ?