1856166 - Opening saved .eml file with X-Unsent has no subject in 115.3.1 (64-bit)

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Bob]

Steps to reproduce:

Open a "saved message" via File/Open/Saved message or double-clicking a file with an eml extension set to open with Thunderbird

Actual results:

The "Write" window opens, but the "Subject" is blank.

Expected results:

The "Subject:" from the "saved message" should be used.
(I have re-installed 115.0 (64-bit), which works correctly).

Comment 1

[Francesco]

That's a message with an X-Unsent header? Otherwise the compose window wouldn't open. A regression of bug 1788534 where obtaining the subject was changed. It is now obtained from the DB, but such a message isn't in the DB.

Comment 2

[Magnus Melin [:mkmelin]]

Since we can't get the db subject in that case, we should not overwrite the subject that mime puts there. https://searchfox.org/comm-central/rev/5c71fbceb55bbff85d911e3dbe41f4b987d0e862/mailnews/mime/src/mimedrft.cpp#345

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1856166 - For compose based on saved .eml, preserve subject already set. r=#thunderbird-reviewers

Trying to get it from db will result in empty subject.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4db8c5d56dd
For compose based on saved .eml, preserve subject already set. r=babolivier

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9356177 [details]
Bug 1856166 - For compose based on saved .eml, preserve subject already set. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1788534
User impact if declined: empty subject for some lesser used compose actions
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9356177 [details]
Bug 1856166 - For compose based on saved .eml, preserve subject already set. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/2cbc543de04b

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9356177 [details]
Bug 1856166 - For compose based on saved .eml, preserve subject already set. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/fb7bb1f0bce8