1856189 - setAttribute("selectedIndex", 0) on <deck> doesn't appear to work

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[betterbird.project+10]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Edg/117.0.2045.43

Steps to reproduce:

In a debugging session we noticed that this line
this._wizardButtonDeck.setAttribute("selectedIndex", 0);
https://searchfox.org/mozilla-central/rev/23808d46cde6155213b1230675b00a0a426f466e/toolkit/content/widgets/wizard.js#622
seems to have no effect. Can be seen by adding console.log() here:
https://searchfox.org/comm-central/rev/38b9c6416aa503df4003dbf400271d1e82f3bc75/mozilla/toolkit/content/widgets/tabbox.js#221

This seems to have regressed by bug 1689816. See Bug 1855807 comment #1 for an analysis. TB decided not to fix this issue, however, this is a toolkit bug which may effect other things.

The fix appears to be a direct assignment as we do here:
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1855807-fix-account-wizard-m-c.patch

Comment 1

[Emilio Cobos Álvarez (:emilio)]

The patch in comment 0 makes sense to me, can you send it via phabricator? Happy to stamp and land.

Comment 2

[betterbird.project+10]

We don't have a Phab account.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1856189 - Use selectedIndex setter on wizard.

Setting the "selectedIndex" attribute doesn't trigger all the relevant
side effects. It's also simpler.

MANUAL PUSH: Author doesn't have a Phab account.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dc70b55b527
Use selectedIndex setter on wizard.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1dc70b55b527

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1689816

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sounds like we might want to get this on ESR115 for the TB folks.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9356099 [details]
Bug 1856189 - Use selectedIndex setter on wizard.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Affects thunderbird, one-liner.
• User impact if declined: see above.
• Fix Landed on Version: 120
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9356099 [details]
Bug 1856189 - Use selectedIndex setter on wizard.

Approved for 115.5esr

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/c528c13ff29a