Closed Bug 1856189 Opened 8 months ago Closed 8 months ago

setAttribute("selectedIndex", 0) on <deck> doesn't appear to work

Categories

(Toolkit :: UI Widgets, defect)

Firefox 115
defect

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox-esr115 --- fixed
firefox118 --- wontfix
firefox119 --- wontfix
firefox120 --- fixed

People

(Reporter: betterbird.project+10, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Edg/117.0.2045.43

Steps to reproduce:

In a debugging session we noticed that this line
this._wizardButtonDeck.setAttribute("selectedIndex", 0);
https://searchfox.org/mozilla-central/rev/23808d46cde6155213b1230675b00a0a426f466e/toolkit/content/widgets/wizard.js#622
seems to have no effect. Can be seen by adding console.log() here:
https://searchfox.org/comm-central/rev/38b9c6416aa503df4003dbf400271d1e82f3bc75/mozilla/toolkit/content/widgets/tabbox.js#221

This seems to have regressed by bug 1689816. See Bug 1855807 comment #1 for an analysis. TB decided not to fix this issue, however, this is a toolkit bug which may effect other things.

The fix appears to be a direct assignment as we do here:
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1855807-fix-account-wizard-m-c.patch

Flags: needinfo?(emilio)
Keywords: regression
Regressed by: 1689816

The patch in comment 0 makes sense to me, can you send it via phabricator? Happy to stamp and land.

Flags: needinfo?(emilio) → needinfo?(betterbird.project+10)

We don't have a Phab account.

Flags: needinfo?(betterbird.project+10)

Setting the "selectedIndex" attribute doesn't trigger all the relevant
side effects. It's also simpler.

MANUAL PUSH: Author doesn't have a Phab account.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dc70b55b527
Use selectedIndex setter on wizard.
Status: UNCONFIRMED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

Set release status flags based on info from the regressing bug 1689816

Assignee: nobody → emilio

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

Sounds like we might want to get this on ESR115 for the TB folks.

Flags: needinfo?(emilio)

Comment on attachment 9356099 [details]
Bug 1856189 - Use selectedIndex setter on wizard.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Affects thunderbird, one-liner.
  • User impact if declined: see above.
  • Fix Landed on Version: 120
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial
Flags: needinfo?(emilio)
Attachment #9356099 - Flags: approval-mozilla-esr115?

Comment on attachment 9356099 [details]
Bug 1856189 - Use selectedIndex setter on wizard.

Approved for 115.5esr

Attachment #9356099 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: