1856270 - Refactor the workflow for showing scopes for original sources

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

Currently "map scopes" is quite hidden and not clear for users

Lets improve the UI Experience

• Show original scopes only when the "map scopes" checkbox is enabled
• Show info which lets the users know that they need to turn on the checkbox to show original scopes.
• Show loading information when original scopes take some time to load.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1856270 - [devtools] Refactor the UI experience for loading original scopes r=#devtools-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a3c66f7fdc
[devtools] Refactor the UI experience for loading original scopes r=devtools-reviewers,ochameau,nchevobbe

Comment 3

[Iulian Moraru]

Backed out for causing dt failures on browser_dbg-reducer-cleanup-on-target-removal.js.

• Push with failures

• Failure log

• Backout link

[task 2023-11-06T15:35:36.155Z] 15:35:36     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-reducer-cleanup-on-target-removal.js | a new breakpoint was created - 
[task 2023-11-06T15:35:36.155Z] 15:35:36     INFO - Waiting for the debugger to pause
[task 2023-11-06T15:35:36.156Z] 15:35:36     INFO - Waiting for state change: paused
[task 2023-11-06T15:35:36.157Z] 15:35:36     INFO - Finished waiting for state change: paused
[task 2023-11-06T15:35:36.158Z] 15:35:36     INFO - Waiting for state change: fetched frames
[task 2023-11-06T15:35:36.159Z] 15:35:36     INFO - Finished waiting for state change: fetched frames
[task 2023-11-06T15:35:36.160Z] 15:35:36     INFO - Buffered messages finished
[task 2023-11-06T15:35:36.161Z] 15:35:36     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-reducer-cleanup-on-target-removal.js | Test timed out - 
[task 2023-11-06T15:35:36.184Z] 15:35:36     INFO - Removing tab.
[task 2023-11-06T15:35:36.187Z] 15:35:36     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2023-11-06T15:35:36.194Z] 15:35:36     INFO - Got event: 'TabClose' on [object XULElement].
[task 2023-11-06T15:35:36.207Z] 15:35:36     INFO - Tab removed and finished closing
[task 2023-11-06T15:35:36.219Z] 15:35:36     INFO - GECKO(2662) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-11-06T15:35:36.220Z] 15:35:36     INFO - GECKO(2662) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-11-06T15:35:36.221Z] 15:35:36     INFO - GECKO(2662) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-11-06T15:35:36.222Z] 15:35:36     INFO - GECKO(2662) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-11-06T15:35:36.222Z] 15:35:36     INFO - GECKO(2662) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-11-06T15:35:36.242Z] 15:35:36     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-reducer-cleanup-on-target-removal.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-11-06T15:35:36.246Z] 15:35:36     INFO - finish() was called, cleaning up and clearing debugger preferences...
[task 2023-11-06T15:35:36.247Z] 15:35:36     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-11-06T15:35:36.250Z] 15:35:36     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-11-06T15:35:36.250Z] 15:35:36     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-11-06T15:35:36.251Z] 15:35:36     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-11-06T15:35:36.254Z] 15:35:36     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-11-06T15:35:36.255Z] 15:35:36     INFO - GECKO(2662) | JavaScript error: , line 0: TimeoutError: Message handler threw uncatchable exception
[task 2023-11-06T15:35:36.274Z] 15:35:36     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-11-06T15:35:36.277Z] 15:35:36     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-reducer-cleanup-on-target-removal.js | A promise chain failed to handle a rejection: Message handler threw uncatchable exception - stack: (No stack available.)
[task 2023-11-06T15:35:36.279Z] 15:35:36     INFO - Rejection date: Mon Nov 06 2023 15:35:36 GMT+0000 (Coordinated Universal Time) - false == true - {"filename":"resource://testing-common/PromiseTestUtils.sys.mjs","name":"assertNoUncaughtRejections","sourceId":591,"lineNumber":266,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest","sourceId":552,"lineNumber":769,"columnNumber":29,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"timeoutFn","sourceId":552,"lineNumber":1440,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":552,"lineNumber":1382,"columnNumber":45,"sourceLine":"","asyncCause":"setTimeout handler","asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":552,"lineNumber":1123,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":582,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1123:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"setTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:1382:45\nnextTest/<@chrome://mochikit/content/browser-test.js:1123:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"async*timeoutFn@chrome://mochikit/content/browser-test.js:1440:18\nsetTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:1382:45\nnextTest/<@chrome://mochikit/content/browser-test.js:1123:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"nextTest@chrome://mochikit/content/browser-test.js:769:29\nasync*timeoutFn@chrome://mochikit/content/browser-test.js:1440:18\nsetTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:1382:45\nnextTest/<@chrome://mochikit/content/browser-test.js:1123:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"assertNoUncaughtRejections@resource://testing-common/PromiseTestUtils.sys.mjs:266:14\nnextTest@chrome://mochikit/content/browser-test.js:769:29\nasync*timeoutFn@chrome://mochikit/content/browser-test.js:1440:18\nsetTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:1382:45\nnextTest/<@chrome://mochikit/content/browser-test.js:1123:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2023-11-06T15:35:36.279Z] 15:35:36     INFO - Stack trace:
[task 2023-11-06T15:35:36.279Z] 15:35:36     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2023-11-06T15:35:36.279Z] 15:35:36     INFO - chrome://mochikit/content/browser-test.js:nextTest:769
[task 2023-11-06T15:35:36.280Z] 15:35:36     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1440
[task 2023-11-06T15:35:36.280Z] 15:35:36     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1382
[task 2023-11-06T15:35:36.280Z] 15:35:36     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1123
[task 2023-11-06T15:35:36.280Z] 15:35:36     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-06T15:35:36.280Z] 15:35:36     INFO - Console message: [JavaScript Error: "TimeoutError: Message handler threw uncatchable exception"]
[task 2023-11-06T15:35:36.571Z] 15:35:36     INFO - GECKO(2662) | MEMORY STAT | vsize 3975MB | residentFast 646MB | heapAllocated 341MB
[task 2023-11-06T15:35:36.572Z] 15:35:36     INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-reducer-cleanup-on-target-removal.js | took 45729ms
[task 2023-11-06T15:35:36.593Z] 15:35:36     INFO - checking window state
[task 2023-11-06T15:35:36.632Z] 15:35:36     INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-remember-expanded-scopes.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e08029e8f01
[devtools] Refactor the UI experience for loading original scopes r=devtools-reviewers,ochameau,nchevobbe

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78e9c2cd0c1d
[devtools] Refactor the UI experience for loading original scopes r=devtools-reviewers,ochameau,nchevobbe,perftest-reviewers,sparky

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/78e9c2cd0c1d