1868541 - 418.65 - 62.57% damp custom.jsdebugger.stepIn.DAMP / damp custom.jsdebugger.stepOut.DAMP + 2 more (OSX) regression on Tue November 14 2023

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance regression from push 1a89f1897f63b225b954c47bc3f75da1f600f6dd. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
419%	damp custom.jsdebugger.stepIn.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	668.01 -> 3,464.62
265%	damp custom.jsdebugger.stepInNewSource.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	690.24 -> 2,517.55
153%	damp custom.jsdebugger.pause.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	291.55 -> 737.11
63%	damp custom.jsdebugger.stepOut.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	602.51 -> 979.48

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858076

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Bug 1856270 enabled map copes in DAMP, but it's still not on by default

Comment 3

[Ryan VanderMeulen [:RyanVM]]

IIUC, this regression is gated behind the devtools.debugger.map-scopes-enabled pref which isn't enabled by default yet.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

IIUC, this regression is gated behind the devtools.debugger.map-scopes-enabled pref which isn't enabled by default yet.

You're right. I think Hubert's intent was to have it enabled in the test so we can see the impact on the work we're going to do in this area. We should probably close this bug, as we'll have much more specific individual bugs to look at this.

Comment 5

[Hubert Boma Manilla (:bomsy)]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

IIUC, this regression is gated behind the devtools.debugger.map-scopes-enabled pref which isn't enabled by default yet.

You're right. I think Hubert's intent was to have it enabled in the test so we can see the impact on the work we're going to do in this area. We should probably close this bug, as we'll have much more specific individual bugs to look at this.

Yes that's the case.
Thanks Nicholas. I'll close this.