Closed Bug 1856287 Opened 7 months ago Closed 7 months ago

Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows

Categories

(Toolkit :: Crash Reporting, enhancement)

Product:
Toolkit
Component:
Crash Reporting
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox120 --- fixed

People

(Reporter: gsvelto, Assigned: tagazeem, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(1 file)

Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r?gsvelto
48 bytes, text/x-phabricator-request
Details | Review

Bug 1476365 comment 4 suggests that our change in bug 1497692 could backfire in case the minidump-analyzer uses more than 32 MiB of memory, possibly slowing it down to the point of making it useless. Using BELOW_NORMAL_PRIORITY_CLASS might be a safer bet.

For those interested in picking up this bug, you can find me in the #crashreporting channel on chat.mozilla.org. The change needs to happen in the sources of the minidump-analyzer here. You must have access to a Windows machine to build and test the patch.

Assignee: nobody → tagazeem
Status: NEW → ASSIGNED

minidum-analyzer in the background on Windows r=gsvelto

Attachment #9356995 - Attachment description: WIP: Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the → WIP: Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r=gsvelto
Attachment #9356995 - Attachment description: WIP: Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r=gsvelto → WIP: Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r?gsvelto
Attachment #9356995 - Attachment description: WIP: Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r?gsvelto → Bug 1856287 - Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r?gsvelto
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38fb0c2583c7
Do not use PROCESS_MODE_BACKGROUND_BEGIN to run the minidum-analyzer in the background on Windows r=gsvelto

https://hg.mozilla.org/mozilla-central/rev/38fb0c2583c7

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: