1856415 - Update clear data dialog UI to match new designs

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement, P2)

Description

[Harshit Sohaney]

Figma link

Comment 1

[Harshit Sohaney]

Attachment: Bug 1856415 - (Part 1) Updating clear data dialog UI. r?pbz

Comment 2

[Phabricator Automation]

Comment on attachment 9356407 [details]
Bug 1856415 - (Part 1) Updating clear data dialog UI. r?pbz

Revision D189947 was moved to bug 1856414. Setting attachment 9356407 [details] to obsolete.

Comment 3

[Harshit Sohaney]

Attachment: Bug 1856415 - make copies of sanitizeDialog files for the new dialog box. r?pbz

Comment 4

[Harshit Sohaney]

Attachment: Bug 1856415 - (Part 2) Testing for new dialog UI. r?pbz

Depends on D189947

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c59242f5f3
make copies of sanitizeDialog files for the new dialog box. r=pbz

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e7c59242f5f3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffd79f9e0881
(Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod
https://hg.mozilla.org/integration/autoland/rev/f5e458c049b9
(Part 2) Testing for new dialog UI. r=pbz

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at browser/base/content/test/static/browser_all_files_referenced.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8f34e74e2dceb7347f4e1b0d0173155cac2d543a

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 6, expected +0

Comment 9

[Harshit Sohaney]

Looks like there was an error with the way I referenced "sanitize_v2.xhtml". Sorry about that, I've fixed it now!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/098f24a13dca
(Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod
https://hg.mozilla.org/integration/autoland/rev/1e891167c753
(Part 2) Testing for new dialog UI. r=pbz

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/098f24a13dca
https://hg.mozilla.org/mozilla-central/rev/1e891167c753