1856509 - Start-up performance regression caused by Find Events pane

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan) [PTO, back 2 Nov]]

Nicolas reports his start-up has slowed to a crawl. We created a performance profile and traced it back to the Find Events panel changes. I'm trying to reproduce it to see if can figure out what's wrong.

This happens even if the Calendar tab is closed, which should mean the Find Events panel does nothing.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 2 Nov]]

Attachment: Bug 1856509 - Prevent the Find Events pane loading all events at start-up. r=leftmostcat

The Find Events tree view is activated at start-up whether it is open or not, and without a start and end date set.
This causes it to load all events in the calendar, which can take a long time, for no reason.

I've prevented the problem in two ways:

• Only activate the view when the Calendar tab is in the foreground and the Find Events panel is opened.
  Deactivate it again if the panel is closed.
• Stop the calendar view mixin from reading from calendars without all of the item type, start date, and end date set.
  ISTR this was the original intention but it got lost somewhere along the way.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a4cb31609e2d
Prevent the Find Events pane loading all events at start-up. r=leftmostcat