1763752 - Upgrade task lists and unifinder to use CalendarFilteredViewMixin instead of calFilter

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement, P2)

Description

[Geoff Lankow (:darktrojan)]

Just like bug 1753558 for the main views and bug 1728743 for the agenda, we now should upgrade the unifinder (find events list) and task lists to use the new code. These pieces currently use the original calFilter class, so upgrading them should allow us to remove most of it and simplify things a lot.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1763752 - Create an nsITreeView backed by CalendarFilteredViewMixin r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1763752 - Update unifinder to use filtered calendar tree view. r=darktrojan

Depends on D169138

Comment 3

[Geoff Lankow (:darktrojan)]

I figured that I would put these up since they have existed for some time now. I'll get around to finishing them some day.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8bcfb152fdbe
Create an nsITreeView backed by CalendarFilteredViewMixin. r=darktrojan

Comment 5

[Magnus Melin [:mkmelin]]

Needs rebasing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/15e6413835fc
Update unifinder to use filtered calendar tree view. r=darktrojan

Comment 7

[Sean Burke [:leftmostcat]]

Comment on attachment 9316454 [details]
Bug 1763752 - Update unifinder to use filtered calendar tree view. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): Not a regression
User impact if declined: Unable to address bug 310853
Testing completed (on c-c, etc.): Present in nightly, manual testing of changes
Risk to taking this patch (and alternatives if risky): Potential bugs in unifinder event listing and filtering, but we want to surface these before sending this to stable

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9316454 [details]
Bug 1763752 - Update unifinder to use filtered calendar tree view. r=darktrojan

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/d634f57cfbf0

Comment 10

[Rob Lemley [:rjl]]

Backout Thunderbird 119.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/5e0dde3a5dbd