1856619 - The Shopping icon is displayed on other already opened tabs after Turning off review checker

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: shopping_icon.gif

Found in

• 119.0b4

Affected versions

• 120.0a1 (2023-10-02)
• 119.0b4

Tested platforms

• Affected platforms: Ubuntu 20, macOS 11, Windows 10x64
• Unaffected platforms: none

Preconditions

• browser.shopping.experience2023.enabled:true

Steps to reproduce

1. Open some random web pages in different tabs.
2. Open a random Amazon product.
3. Opt in and then Turn off review checker from Settings.
4. Select tabs from step 1.

Expected result

• The shopping icon is not displayed.

Actual result

• The shopping icon is displayed.

Regression

• Most likely started after the implementation of bug 1854243.

Additional notes

• Aattached a screen recording.
• The icon is displayed on the other tabs until is clicked.

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Per slack conversation.

Comment 2

[:Gijs (he/him)]

Confirmed with mozregression that this broke in bug 1854243.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1856619 - drop optedOut from conditions that toggle _enabled so shopping button keeps updating on tabswitch/navigation, r?jhirsch

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1856619 - factor out updates to shopping urlbar button and sidebar related to prefs vs related to navigation and tabswitches, r?jhirsch

Depends on D190212

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7536721840c3
drop optedOut from conditions that toggle _enabled so shopping button keeps updating on tabswitch/navigation, r=jhirsch

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7536721840c3

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Phabricator Automation]

Comment on attachment 9356903 [details]
Bug 1856619 - factor out updates to shopping urlbar button and sidebar related to prefs vs related to navigation and tabswitches, r?jhirsch

Revision D190214 was moved to bug 1857524. Setting attachment 9356903 [details] to obsolete.

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1856619 - drop optedOut from conditions that toggle _enabled so shopping button keeps updating on tabswitch/navigation, r?jhirsch

Original Revision: https://phabricator.services.mozilla.com/D190212

Comment 10

[Phabricator Automation]

Uplift Approval Request

• Explanation of risk level: 1.5 line change, comes with automated test to avoid regressions
• Is Android affected?: no
• Steps to reproduce for manual QE testing: See comment 0
• User impact if declined: Shopping urlbar buttons show up everywhere which is wrong
• Fix verified in Nightly: no
• Risk associated with taking this patch: Low
• Needs manual QE test: yes
• String changes made/needed: No
• Code covered by automated testing: yes

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9357063 [details]
Bug 1856619 - drop optedOut from conditions that toggle _enabled so shopping button keeps updating on tabswitch/navigation, r?jhirsch

Approved for 119.0b7

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4816a8c9639e

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 120.0a1 (2023-10-08) as well as our latest Beta 119.0b7.