1856700 - shouldn't load libotr if we don't have a chat account

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Magnus Melin [:mkmelin]]

Even for profiles without a chat account, on startup I see

console.debug: "Trying to load /home/...... /mozilla/obj-x86_64-pc-linux-gnu/dist/bin/libotr.so"
console.debug: "Trying to load libotr.so from system's standard library locations"
console.debug: "Successfully loaded OTR library libotr.so from system's standard library locations"

Nothing should be written when we're successful. And we shouldn't load libotr if there is no chat account set up.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1856700 - avoid loading OTR before we have any chat acccounts. r=freaktechnik

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c825b523851c
avoid loading OTR before we have any chat acccounts. r=freaktechnik

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9356455 [details]
Bug 1856700 - avoid loading OTR before we have any chat acccounts. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): never worked
User impact if declined: unneeded loading of library (small perf issue)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9356455 [details]
Bug 1856700 - avoid loading OTR before we have any chat acccounts. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 119.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/0b870edbb590

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9356455 [details]
Bug 1856700 - avoid loading OTR before we have any chat acccounts. r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/69968cfec854