1856719 - Fix and re-enable Websockets mochitests on Android

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, task, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

They were disabled a long time ago by bug 982828. I took a quick look on Try and some do appear to pass these days, but overall the failure rate is still pretty high. I'm wondering if they might be relatively easily fixed, however?
https://searchfox.org/mozilla-central/source/dom/websocket/tests/mochitest.ini#3

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ PTO until Nov 5 }}]

Enabling the tests and running on emulator I can see them erroring out with the message here:
https://searchfox.org/mozilla-central/rev/9bc264fbc5d6e618d8f3b9677a8f5e8550b94dbc/testing/mochitest/ssltunnel/ssltunnel.cpp#843

(" could not open connection to the real server\n"));

Not sure if what we need here is to forward the port or to fix something with where we forward it.

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ PTO until Nov 5 }}]

Attachment: Bug 1856719 - Make websocket server listen on all interfaces to make Android tests work r=#necko

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:valentin, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Valentin Gosu [:valentin] (he/him) {{ PTO until Nov 5 }}]

I did a try push with ssltunnel logging to figure out why it's not working on treeherder
https://treeherder.mozilla.org/jobs?repo=try&revision=4e61d3d755ba661cbf2c61764d110a015aaf3ccb

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9793d58574ba
Make websocket server listen on all interfaces to make Android tests work r=necko-reviewers,kershaw

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9793d58574ba