Incorrect error message displayed for unsupported products instead of "We can't check these reviews" error message
Categories
(Fenix :: Shopping, defect, P1)
Tracking
(firefox118 disabled, firefox119 disabled, firefox120 verified)
People
(Reporter: dpop, Assigned: rsainani)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [fakespot-android-mvp])
Attachments
(5 files)
Preconditions
Make sure you have VPN connected to US.
Make sure you have developer's option enabled, and the "Shopping experience" toggle is ON.
Enroll in the Fakespot shopping experience.
Steps to reproduce
- Go to a gift card, streaming video, music or games product detailed page from amazon.com, bestbuy.com, or walmart.com.
- Tap the price tag icon in the URL.
- Observe the bottom sheet.
Expected behavior
The "We can't check these reviews" error message is displayed for these types of products.
Actual behavior
The user is prompted to start the analysis, after which the "No info available" error message is displayed.
Device information
- Firefox version: Nightly 120.0a1 from 10/04
- Android device: any device
Any additional information?
After analyzing the product once and closing the bottom sheet, the next time the bottom sheet is opened, the error message would persists (the user is not prompted to analyze the product again).
This issue could be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1856797, however, we receive the same incorrect error message on older Nightly builds as well.
Reporter | ||
Comment 1•1 year ago
|
||
The appropriate error massage, as per the Figma design.
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Reporter | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Comment 2•1 year ago
|
||
Comment 3•1 year ago
|
||
Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/11f73ad3a5540563244d676b10fe85e10e2a78be
[main] Bug 1856959 - Fix review checker unsupported product error case
Comment 4•1 year ago
|
||
Can you please share a screenshot of the error message in production? I'm unable to trigger it. Thanks!
Assignee | ||
Comment 5•1 year ago
|
||
Comment 6•1 year ago
|
||
I tried both pdps in the latest Nightly build but I'm still getting the generic error.
Comment 7•1 year ago
|
||
Verified as fixed on Nightly 120.0a1 from 10/19 with Google Pixel 7 Pro ( Android 14) and OnePlus A3000 (Android 6).
Comment 8•1 year ago
|
||
Assignee | ||
Comment 9•1 year ago
|
||
[:emilyw] If you check now, it should be in nightly as it's been marked verified now. It usually takes a day for a bug marked "fixed" aka landed, to be released in nightly.
Comment 10•1 year ago
|
||
[:rsainani] Thank you for that! I see it fixed now.
Description
•