1857037 - Cleanup BUILD.gn files changes in third_party/libwebrtc/third_party

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

There are many changes to the BUILD.gn files in libwebrtc/third_party that are not really necessary to generate the same moz.build file output. These changes make merge conflicts more likely when updating to newer versions. Also, as additional mozilla third_party libs are starting to rely on this particular import (namely abseil-cpp), updates may be more common than in the past.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1857037 - pt1 - add shim gni files to limit BUILD.gn changes. r?ng!

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1857037 - pt2 - cleanup libwebrtc/third_party BUILD.gn changes. r?ng!

Many of these files are now in unmodified form. These changes produce
no changes when running:
./mach python python/mozbuild/mozbuild/gn_processor.py dom/media/webrtc/third_party_build/gn-configs/webrtc.json

Depends on D190104

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a84d39db037c
pt1 - add shim gni files to limit BUILD.gn changes. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/34c8904c816a
pt2 - cleanup libwebrtc/third_party BUILD.gn changes. r=ng,webrtc-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a84d39db037c
https://hg.mozilla.org/mozilla-central/rev/34c8904c816a

Comment 5

[Jason Prickett]

Attachment: Bug 1857037 - create asrouter targeting for primary monitor resolution r?#omc-reviewers

Comment 6

[Phabricator Automation]

Comment on attachment 9357686 [details]
Bug 1857037 - create asrouter targeting for primary monitor resolution r?#omc-reviewers

Revision D190615 was moved to bug 1857036. Setting attachment 9357686 [details] to obsolete.