Closed Bug 1857037 Opened 1 year ago Closed 1 year ago

Cleanup BUILD.gn files changes in third_party/libwebrtc/third_party

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

Attachments

(2 files, 1 obsolete file)

There are many changes to the BUILD.gn files in libwebrtc/third_party that are not really necessary to generate the same moz.build file output. These changes make merge conflicts more likely when updating to newer versions. Also, as additional mozilla third_party libs are starting to rely on this particular import (namely abseil-cpp), updates may be more common than in the past.

Assignee: nobody → mfroman
Depends on: 1855330
Priority: -- → P2

Many of these files are now in unmodified form. These changes produce
no changes when running:
./mach python python/mozbuild/mozbuild/gn_processor.py dom/media/webrtc/third_party_build/gn-configs/webrtc.json

Depends on D190104

Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a84d39db037c pt1 - add shim gni files to limit BUILD.gn changes. r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/34c8904c816a pt2 - cleanup libwebrtc/third_party BUILD.gn changes. r=ng,webrtc-reviewers
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

Comment on attachment 9357686 [details]
Bug 1857037 - create asrouter targeting for primary monitor resolution r?#omc-reviewers

Revision D190615 was moved to bug 1857036. Setting attachment 9357686 [details] to obsolete.

Attachment #9357686 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: