Convert addon suggestions from dynamic to standard results
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
This is spun out from bug 1857108. That bug fixes the title separator for addon and weather rows, except when wrap is set the separator still disappears for addon suggestions. There's not a nice way to fix that without adding back some rules that bug 1855639 removed or adding some new addon-specific rules when wrap is set.
Instead, I'd like to convert addon rows from dynamic to standard. That will fix the separator as well as allow the URL to wrap under the title, which isn't currently implemented for addon rows. Two more reasons are that we no longer need to implement the review-star UI, and at the time addon suggestions were implemented standard rows didn't support bottom text but they do now.
I checked with Daisuke and he's OK with this.
|
Assignee | |
Comment 1•9 months ago
|
||
This converts addon suggestions from dynamic to standard results and removes
support for review stars. Other things worth noting:
- I removed
suggestion.is_top_picksupport because addons should always be top
picks. This lets us simplify the code and tests. - This changes the overall icon box size for addons from 60px to 52px, since it
combines the icon rules for Pocket and addons. I checked with Josh, and he
says that's fine (Slack) - Currently the default
-webkit-line-clampis 3 and MDN and Pocket rows
override it by setting it to 2. I think the opposite makes more sense, i.e.
the default should be 2, since there are no row types that need it to be 3.
This lets me avoid adding a rule for addon rows. (-webkit-line-clampwas
added in D185247)
Depends on D190138
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2e9bd788911 Convert addon suggestions from dynamic to standard results. r=daisuke,desktop-theme-reviewers,dao
|
||
Comment 3•9 months ago
|
||
| bugherder | ||
Description
•