1857108 - Fix missing title separator in Suggest rows

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

Addon rows have a couple problems:

• The title separator is missing due to bug 1855639. The simplifications made by that bug are good though, so rather than adding back a rule specifically for addon suggestions in urlbarView.css, we should either add a rule to urlbar-dynamic-results.css or maybe better set has-url on addon rows.
• Per Josh on Slack, the icon is too big. The Figma shows the icon at 24x24px insde a larger gray 60x60px box.

Comment 1

[Drew Willcoxon :adw]

The title separator in weather is missing too.

Comment 2

[Drew Willcoxon :adw]

I'll split off the icon issue into its own bug.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1855639

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1857108 - Set has-url on dynamic-result-type rows when they contain a URL.

This sets has-url on dynamic-result-type rows when their view template
contains a .urlbarView-url element. This fixes the missing separator in both
addon and weather rows.

This does not address one remaining problem: When wrap is set, the separator
is still missing in addon rows because they don't handle wrapping. Prior to
bug 1855639, they just always showed their title separator, and since they don't
wrap their URL, that was fine. I'd like to handle that separately by converting
addon rows from dynamic to standard. I filed bug 1857137 for that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/708b3c93b4fd
Set has-url on dynamic-result-type rows when they contain a URL. r=dao

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/708b3c93b4fd

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-10-04 Nightly build on Ubuntu 22.
Verified as fixed on Firefox Nightly 120.0a1(build ID: 20231011211944) on Ubuntu 22, Windows 10, macOS 12.
Add-on title separator is now present.
Add-on icons are now smaller and placed inside a gray box.