1857172 - Build fails because clap_builder v4.4.5 requires rustc 1.70.0 or newer

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attempting to run a build today, it fails with:

17:24.57 error: package `clap_builder v4.4.5` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.66.0
17:24.57 Either upgrade to rustc 1.70.0 or newer, or use
17:24.57 cargo update -p clap_builder@4.4.5 --precise ver
17:24.57 where `ver` is the latest version of `clap_builder` supporting rustc 1.66.0

It looks like the latest version that is installed by bootstrap is 1.66.0.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1857172 - Bump the minimum version of Rust to 1.70.0.

Strictly speaking, we could revert bug 1857172 and keep the minimum on
1.66, there are enough new goodies in 1.70, and it's old enough per
policy.

Comment 2

[Mike Hommey [:glandium]]

It's quite unfortunate that this wasn't caught by the base-toolchain jobs... because automation doesn't build geckodriver while building Firefox... Might be worth adding --enable-geckodriver to the base-toolchain jobs...

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1857172 - Force build geckodriver in base-toolchain tasks.

Comment 4

[BugBot [:suhaib / :marco]]

:glandium, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit BugBot documentation.

Comment 5

[Mark Banner (:standard8)]

My fault, I put that bug in the wrong field.

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1855619

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4929a396d0fb
Bump the minimum version of Rust to 1.70.0. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/47b3aca3172e
Force build geckodriver in base-toolchain tasks. r=firefox-build-system-reviewers,sergesanspaille

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4929a396d0fb
https://hg.mozilla.org/mozilla-central/rev/47b3aca3172e