1857205 - Setting to specify functionality of Cmd+shift+T Shortcut

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, defect, P3)

Description

[FFFan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

Since the latest update the functionality of CMD+Shift+T (Mac) / Ctrl+Shift+T seems to have changed to the worse.
It used to be the case that FF kept a per-window tab history so you could reopen closed tabs and closed windows independently.
This was very useful and a real differentiating factor from other browsers, the main reason I use Firefox.

STR:
Open A Window (Window 1), leading to Tab 1 opening
Open Tab 2
Open a separate Window (Window 2), leading to Tab 3 opening
Close Tab 2 (In Window 1)
Close Window 2

Actual results:

Window 1 (only remaining window) is focused.
CMD+Shift+T will re-open Window 2, another press will open Tab 2.

Expected results:

Previously CMD+Shift+T would have re-opened Tab 2. Another press would have had no effect.
CMD-Shift+N would have re-opened Window 2.

Can we get this feature back, at least as a setting?
Separate Macos Menu Commands would be sufficient, if the Keyboard shortcut is not to be be restored to previous functionality out of the box.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Stephen A Pohl [:spohl] (OOO until 9/15)]

Could you run mozregression to see when this started happening? If you have never run mozregression before, simply run these three commands in a Terminal window:

sudo easy_install pip
sudo python3 -m pip install -U mozregression --ignore-installed
mozregression --good 2017-01-01

A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!

Comment 3

[FFFan]

Yes, here we are:

18:07.31 INFO: Last good revision: f1fb26526a2e8e7d9539b3f975817b0578e1bc0c
18:07.31 INFO: First bad revision: a44656c2ad83d278286aa51507864e53a3911df3
18:07.31 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f1fb26526a2e8e7d9539b3f975817b0578e1bc0c&tochange=a44656c2ad83d278286aa51507864e53a3911df3

I can read from the related release notes, that this change was intentional. I wish to weigh in on that decision but think this is not the forum.
Another negative side-effect I found while testing is the following, and this should be an actual bug:

STR:
Open A Window (Window 1), leading to Tab 1 opening
Open Tab 2
Open a separate Window (Window 2), leading to Tab 3 opening
Open Tab 4 in Window 2

Close Tab 2 (In Window 1)
Close Tab 4 (In Window 2)
Close Tab 3 (In Window2)

Restore tabs 3 and 4 by pressing keyboard shortcut twice
Press Keyboard shortcut again –> Tab 2 can no longer be restored via shortcut.

Comment 4

[Stephen A Pohl [:spohl] (OOO until 9/15)]

Thank you for running mozregression. I'm going to close this bug as wontfix, since this was intentionally changed in bug 1857205. Please file a new bug for the other issue that you're encountering. Thank you!

Comment 5

[Karl Tomlinson (:karlt)]

I think browser.sessionstore.closedTabsFromAllWindows may be the preference that you want.
Perhaps browser.sessionstore.closedTabsFromClosedWindows may also be required.