1857332 - Always cap try tasks to a 28 days expiry

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Mike Hommey [:glandium]]

This was originally done in bug 1677020, but was lost in bug 1649987.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1857332 - Remove redundant artifact expiry calculation.

It's already handled in set_task_and_artifact_expiry.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1857332 - Always cap try tasks to a 28 days expiry.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1857332 - Also apply the try expiry cap to expiration-policies.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1649987

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba8eb88be943
Remove redundant artifact expiry calculation. r=taskgraph-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/cc744831ed67
Always cap try tasks to a 28 days expiry. r=taskgraph-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/2a06105b47d4
Also apply the try expiry cap to expiration-policies. r=taskgraph-reviewers,jcristau

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ba8eb88be943
https://hg.mozilla.org/mozilla-central/rev/cc744831ed67
https://hg.mozilla.org/mozilla-central/rev/2a06105b47d4

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1857332 - Allow for try-comm-central to have 28 day capped artifact expiration. r=#taskgraph-reviewers,jcristau

Replace hardcoded "try" with actual repository from comfig.parameters to allow
for try-comm-central.

Comment 9

[Rob Lemley [:rjl]]

Reopening to get a fix for try-comm-central artifacts.

Comment 10

[Rob Lemley [:rjl]]

Abandoning the try-comm-central fix here as the scope balloons to way more than I can work on, and there is a workaround that I can accept.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9356940 [details]
Bug 1857332 - Remove redundant artifact expiry calculation.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a required dependency for uplifting bug 1855814 to ESR.
• User impact if declined: Same as bug 1855814 comment 6.
• Fix Landed on Version: 120
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These patches will only impact try pushes against ESR and their impact is minor. It's just about tweaking the expiry of tasks and artifacts on Tasckluster.

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9356940 [details]
Bug 1857332 - Remove redundant artifact expiry calculation.

Approved for 115.14esr

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9356941 [details]
Bug 1857332 - Always cap try tasks to a 28 days expiry.

Approved for 115.14esr

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9356942 [details]
Bug 1857332 - Also apply the try expiry cap to expiration-policies.

Approved for 115.14esr

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/f382902a1c15
https://hg.mozilla.org/releases/mozilla-esr115/rev/7a6e9f9498f6
https://hg.mozilla.org/releases/mozilla-esr115/rev/0add2e88d6ce