1677020 - Always cap try tasks to a 28 days expiry

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

Currently, if a task defines its own expiry with a very large value, that will be respected even on try, where we actually don't want that to happen.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1677020 - Always cap try tasks to a 28 days expiry.

Currently, if a task defines its own expiry with a very large value,
that will be respected even on try, where we actually don't want that to
happen.

This also helps simplify the setup for docker images.

We also take on the occasion to remove the discrepancy between the
default expiry for tasks in general and tests in particular. Bug 1258497
set the original expiry to 14 days, bug 1281004 added another place
where the expiry was set to 14 days for tests specifically, and then bug
1304180 changed the expiry to 28 days, but it just seems the location
for tests was overlooked rather than deliberately left to 14 days.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5054f02d1db1
Always cap try tasks to a 28 days expiry. r=taskgraph-reviewers,jmaher

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5054f02d1db1

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9187582 [details]
Bug 1677020 - Always cap try tasks to a 28 days expiry.

Beta/Release Uplift Approval Request

• User impact if declined: Indirect dependency of bug 1678485
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Decision task change only. Not strictly necessary, but nice to have.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9187582 [details]
Bug 1677020 - Always cap try tasks to a 28 days expiry.

Approved for 84.0b4.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce8b69478713