Closed Bug 1857413 Opened 2 years ago Closed 1 year ago

Intermittent comm/mail/base/test/browser/browser_subscribe.js | false == true

Categories

(Thunderbird :: Mail Window Front End, defect, P5)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect

Tracking

(thunderbird_esr128 fixed)

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
thunderbird_esr128 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

References

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(2 files, 1 obsolete file)

Bug 1857413 - Set min-height on subscribe dialog's <dialog> element. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
corey
: approval-comm-esr128+
Details | Review
Bug 1857413 - Fix browser_subscribe.js by waiting for the right thing. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
corey
: approval-comm-esr128+
Details | Review

Fails locally as well using ./mach test --headless --verify comm/mail/base/test/browser/browser_subscribe.js

The patch shows a bit easier what goes wrong. But it still fails locally with --verify. Giving up for now.

Attachment #9357007 - Attachment is obsolete: true

Unfortunately bug 1710319 didn't fix it, but it did prove I was on the right track. I think I know how to make this dialog's contents fill the frame immediately on opening now.

Assignee: nobody → geoff
Status: NEW → ASSIGNED

This isn't perfect, the dialog is slightly too short on Windows, but it's better than it was. It's the same thing we do on several other dialogs.

That's not the problem either. I should actually read the logs.

This waitForCondition call is just waiting for the right number of rows. There could be the right
number of rows part-way through updating the tree, if a row gets added before the row to be removed
gets removed, and this seems to be what happens in most if not all cases.

Attachment #9432759 - Attachment description: Bug 1857413 - Fix browser_subscribe by waiting for the right thing. r=#thunderbird-reviewers → Bug 1857413 - Fix browser_subscribe.js by waiting for the right thing. r=#thunderbird-reviewers
Keywords: checkin-needed-tb
Target Milestone: --- → 133 Branch

Pushed by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/42b51241ab65
Fix browser_subscribe.js by waiting for the right thing. r=mkmelin
https://hg.mozilla.org/comm-central/rev/1ed7562b3bf9
Set min-height on subscribe dialog's <dialog> element. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Duplicate of this bug: 1926865

Comment on attachment 9432759 [details]
Bug 1857413 - Fix browser_subscribe.js by waiting for the right thing. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: just a test fix
Testing completed (on c-c, etc.): on comm-central a week and comm-beta a few days, the test has stopped failing
Risk to taking this patch (and alternatives if risky): nope

Attachment #9432759 - Flags: approval-comm-esr128?

Comment on attachment 9432724 [details]
Bug 1857413 - Set min-height on subscribe dialog's <dialog> element. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: the subscribe dialog doesn't initially lay itself out properly
Testing completed (on c-c, etc.): on comm-central a week, on comm-beta a few days
Risk to taking this patch (and alternatives if risky): very low

Attachment #9432724 - Flags: approval-comm-esr128?

Comment on attachment 9432724 [details]
Bug 1857413 - Set min-height on subscribe dialog's <dialog> element. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Attachment #9432724 - Flags: approval-comm-esr128? → approval-comm-esr128+

Comment on attachment 9432759 [details]
Bug 1857413 - Fix browser_subscribe.js by waiting for the right thing. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Attachment #9432759 - Flags: approval-comm-esr128? → approval-comm-esr128+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: