1857513 - Bookmark sidebar tooltips no longer appear on hover when sidebar is not focused

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Kestrel]

STR:

1. Open the bookmarks sidebar (Ctrl+B) on Ubuntu 23.04.
2. Click in the browser content to focus it.
3. Hover the mouse cursor over a bookmark in the sidebar.

Expected:
Hover tooltip appears, revealing the full bookmark title.

Actual:
Even though the browser window is active, tooltips won't appear until after clicking inside the sidebar.

The sidebar is focused when it is first opened and when the user clicks in it (eg to open a folder), but otherwise it will not be focused and so tooltips won't work the majority of the time. Tooltips are essential to see full bookmark titles due to the narrow width of the sidebar.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5ed2d82563db9ab07b081fa10544fb713c174dc2&tochange=8ae372dc88d1d1b1b5fd4783aec003da378c3e45

Regressed by Bug 148624.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:fanzhuyifan+github, since you are the author of the regressor, bug 148624, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[fanzhuyifan+github]

The regressing commit (https://phabricator.services.mozilla.com/D187418) changes the previous behavior to only displaying tooltips when the document has focus, which causes the regression. I guess we need the method mentioned by mstange for a proper fix not causing regressions:

I think a better fix would be for widget to send a window-level mouse exit event when the workspace switch happens. But I'm not sure where that code would go or how we would detect this situation.

Comment 3

[fanzhuyifan+github]

See also the discussion in https://phabricator.services.mozilla.com/D187749
For some reason when the changing the cpp code, a similar regression happened.
The final changed version changes the JS code, and does not have a regression.

Comment 4

[Donal Meehan [:dmeehan]]

:neil deakin could this be triaged for severity?

Comment 5

[Donal Meehan [:dmeehan]]

:emilio anything we can expect for Fx119, we are in the final week of beta

Comment 6

[Donal Meehan [:dmeehan]]

Actually, is this a duplicate of Bug 1852191?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

It's not.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1857513 - Use window activeness rather than document.hasFocus() to display chrome-only tooltips. r=smaug,edgar

This is hard to test because it requires a chrome-only subdoc like a
sidebar. Should be doable even though I'm a bit short on time.

Window activeness gets propagated from toplevel properly.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1857513 - Clean up document state setup. r=smaug,edgar

Now that we have a DocumentState type we can be a bit less explicit
(before this used EventStates, so the extra Document in the names was
useful).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cbf370b4e16
Use window activeness rather than document.hasFocus() to display chrome-only tooltips. r=smaug

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8315a0f0933b
Clean up document state setup. r=smaug

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4cbf370b4e16

Comment 13

[Donal Meehan [:dmeehan]]

:emilio could you add a beta uplift request on this when ready?

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9357654 [details]
Bug 1857513 - Use window activeness rather than document.hasFocus() to display chrome-only tooltips. r=smaug,edgar

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tweaks a condition to handle subdocuments like sidebars properly.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8315a0f0933b

Comment 16

[Donal Meehan [:dmeehan]]

Comment on attachment 9357654 [details]
Bug 1857513 - Use window activeness rather than document.hasFocus() to display chrome-only tooltips. r=smaug,edgar

Approved for 119.0b9

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5aa198b1f23a

Comment 18

[Monica Chiorean]

I was able to reproduce the issue on Ubuntu 20.04 using FF build 119.0a1(20230909211202).
Verified as fixed on Ubuntu 20.04/ WIn10 / Mac 12.6 using FF build 120.0a1(20231012093726).

Pending verification on Beta 119.0b9.

Comment 19

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2023-10-06, on macOS 10.15
Verified as fixed on Firefox 119.0b9 (20231013091412) on macOS 10.15, Windows 10 and Ubuntu 22.04.