1857555 - Remove any mention of Firefox accounts in l10n strings

Status: RESOLVED FIXED

(Thunderbird :: L10n, task)

Description

[Brendan Abolivier [:babolivier]]

Firefox Accounts are getting renamed into Mozilla Accounts on Nov 1st.

The string appears in our l10n strings here: https://searchfox.org/comm-central/source/mail/locales/en-US/messenger/firefoxAccounts.ftl

Comment 1

[Jessilyn Davis]

Can you take a look at the context of where this string shows up for customers and see if it can be renamed to "account" and the Firefox branding taken out of it? (go the agnostic branding route that can be updated at any time vs. having to coordinate the "Mozilla account" launch on 1 Nov?)

Thanks!

Comment 2

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1857555 - Replace Firefox Accounts with Mozilla Accounts in l10 strings. r=#thunderbird-reviewers

Comment 3

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1857555 - Remove reference to Firefox accounts in l10 strings. r=#thunderbird-reviewers

Comment 4

[Brendan Abolivier [:babolivier]]

Ah, I've just noticed your message, I'll have a look at that on Monday then.

Comment 5

[Jessilyn Davis]

Brilliant! Thank you Brendan!

Comment 6

[Brendan Abolivier [:babolivier]]

Attachment: Screenshot from 2023-10-09 17-43-01.png

Right, I've had a look at how we use the strings. As I assumed it's related to our ongoing work to integrate syncing with Firefox/Mozilla accounts in Thunderbird, which means that - good news - it's limited to nightly builds. It looks like the only string with the branding is shown in a popup that only appears in the context of sync (see attachment), which should make it unambiguous what account we're referring to. So going the branding-agnostic way doesn't sound like it's going to create an issue. I'll update the patch to reflect this.

Alex, does this sound good to you? If so, do you also want me to rename the class and function names that refer to FxA/Firefox accounts?

Comment 7

[Alessandro Castellani [:aleca]]

Alex, does this sound good to you?

yes, sounds good.

If so, do you also want me to rename the class and function names that refer to FxA/Firefox accounts?

We can do that in a follow up work as this bug should remain targeted to string changes.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9b9889b538dd
Remove reference to Firefox accounts in l10 strings. r=mkmelin,rjl

Comment 9

[Brendan Abolivier [:babolivier]]

Backed out for causing test failures: https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=TZvfPUsSSrSqtTbvCBSOqA.0

Comment 10

[Brendan Abolivier [:babolivier]]

Test failures were caused by a typo in the file name, I've fixed the phabricator revision, and will land it in the next push.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e12f3518e2e1
Remove reference to Firefox accounts in l10 strings. r=mkmelin,rjl

Comment 12

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1857555 - Follow-up fix to the Fluent migration. r=rjl

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d289955c34f7
Follow-up fix to the Fluent migration. r=rjl