1857558 - [a11y] Review Checker CFR panel is missing accessible name when it is shown

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: CFR-panel-announcement.png

STR:

1. Ensure a TalkBack is running
2. Open a new Firefox Nightly build
3. Navigate to any Amazon product page to get a Review Checker CFR callout listen to the screen reader's announcement

Expected:

1. When CFR panel is opened, it is either expected to announce the top of the popup content or all of the panel's content, or to announce a descriptive accessible name, i.e. Review Checker, Review Checker invitation, or Try Review Checker or Find if you can trust this product..., or generic-like Panel is opened, etc.

Actual:

1. TB announces: panel.org.mozilla.fenix/org.mozilla.fenix.App which is not human-understandable and not descriptive, yet it still manages to hint that there is a panel shown with a content to be reviewed.
   • Since the panel is locking the TB focus on its elements and explore-by-touch does not work (nothing is being announced with it) basically hiding the rest of the on-screen element from a screen reader, it is important to communicate to a user that (1) there is a panel opened and (2) what is the purpose of this panel, thus the access-s2 severity is assigned to this bug

Device: Samsung Galaxy A54 running Androd 13 (One UI 5.1)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:rsainani, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1857558 - [a11y] Dictate Correct CFR Popup Title (#4101)

Comment 3

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/8c45d171ed54c016804b5099e3d5a8ccf45c63f0
[main] Bug 1857558 - [a11y] Dictate Correct CFR Popup Title

Comment 4

[miralobontiu]

Verified that the shopiing CFR is announced as a "Pop-up window" when displayed.
Tested on the latest Fenix Nightly 122.0a1 from 11/21 with Samsung Galaxy Note 8 (Android 9).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:vdreghici, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Vlad Dreghici [:vdreghici]]

I would rather not uplift this since it affects all CFRs, not only shopping.