1857753 - Buttons of warning headers bar aren't totally themed with Dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB 119.0b3 VS TB 120.0a1.png

STR:

1. Check that the pref "Allow remote content in messages" is disabled (default)
2. Select an email with remote content

Actuals:

• The "Preferences" button background is transparent
• The close button has no border

Expected:

• The "Preferences" button background should be themed & be gray
• The close button should have a light gray border

Found on Daily 120.0a1 20231007100943
Still working on 119.0b3 20231004180144 (not sure until which Daily version of 119, so no flag set)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1857753 - Make the Message Bar work with dark themes again. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e72132be66f9
Make the Message Bar work with dark themes again. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

I think this failure is from this: https://treeherder.mozilla.org/logviewer?job_id=432109857&repo=comm-central&lineNumber=6012

Probably because of treating the host pseudo class as taking arguments?

Edit: here's such a selector: :host(:is(.anonymous-content-host, notification-message))([type="info"]) where you have :host(:is(foo))(bar) which has a (bar) at the end?

Comment 4

[Magnus Melin [:mkmelin]]

I filed bug 1858445 for that

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9357285 [details]
Bug 1857753 - Make the Message Bar work with dark themes again. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/bce26c1dda39

Comment 7

[Nicolas Mandil (:NicolasWeb)]

Attachment: 120.0a1 Build 20231017100726 - wrong background for the warning bar

The whole background of the Message bar became gray instead just the button background (with a yellow bar background).

Alex, this isn't a UI change wanted for dark theme but a bug, right ?

Comment 8

[Alessandro Castellani [:aleca]]

Please do not reopen closed bugs.
Open a follow up bug and specify version and OS

Comment 9

[Alessandro Castellani [:aleca]]

Also, we already have a a regression identified in bug 1858445, which is a simple CSS issue.
This will be fixed soon.
No need to open another bug