1857834 - Upgrade to Prettier v3

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Logan Rosen [:Logan]]

We're currently using Prettier v2. Prettier v3 with changes/improvements to formatting; we should upgrade to it.

Comment 1

[Logan Rosen [:Logan]]

Attachment: Bug 1857834 - update to Prettier v3 r?#linter-reviewers

Comment 2

[Logan Rosen [:Logan]]

Attachment: Bug 1857834 - fix bug in fxview-tab-list.mjs r?#fxview-reviewers

There are two equals signs when there should be just one. This was made more obvious after applying Prettier v3's auto formatting.

Depends on D190410

Comment 3

[Logan Rosen [:Logan]]

Attachment: Bug 1857834 - disable Prettier for XHTML r?#linter-reviewers

Prettier v3 has regressions in XHTML formatting and apparently never supported that format to begin with (see this bug). Disabling XHTML auto-formatting with Prettier accordingly.

Depends on D190411

Comment 4

[Logan Rosen [:Logan]]

Attachment: Bug 1857834 - auto-formatting with Prettier v3 r?#linter-reviewers

#ignore-this-changeset

Depends on D190412

Comment 5

[Logan Rosen [:Logan]]

I just tried this again now that Bug 1857999 was fixed, but there are test failures because Prettier now downcases DOCTYPE to doctype, and the XHTML parser does not allow this. Looks like we now need to wait on https://github.com/prettier/prettier/issues/15476 (which the maintainer seems to be addressing despite the lack of official support for XHTML).

Comment 6

[Phabricator Automation]

Comment on attachment 9357315 [details]
Bug 1857834 - fix bug in fxview-tab-list.mjs r?#fxview-reviewers

Revision D190411 was moved to bug 1860931. Setting attachment 9357315 [details] to obsolete.

Comment 7

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 8

[Mark Banner (:standard8)]

Logan, it looks like the Prettier issue is finally fixed, would you be interested in picking this up again?

Comment 9

[Logan Rosen [:Logan]]

Sure thing, I can pick this back up.

Comment 10

[Logan Rosen [:Logan]]

Attachment: Bug 1857834 - auto-formatting with Prettier v3 r?#linter-reviewers

ignore-this-changeset

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205faab59863
update to Prettier v3 r=linter-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/288a8387ab8a
auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/205faab59863
https://hg.mozilla.org/mozilla-central/rev/288a8387ab8a

Comment 13

[Mark Banner (:standard8)]

Thank you for working on this Logan, very nice to get that updated.