1860931 - Incorrect assignment to sourceWindowId in tab list

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect)

Description

[Logan Rosen [:Logan]]

In the Firefox View tab list code, the sourceWindowId attribute of the tab row is incorrectly assigned with two equals signs instead of one. Unclear what the impact of this is, but it does not appear to be correct.

Comment 1

[Logan Rosen [:Logan]]

Attachment: Bug 1860931 - fix bug in fxview-tab-list.mjs r?#fxview-reviewers

There are two equals signs when there should be just one. This was made more obvious after applying Prettier v3's auto formatting.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1845836

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc00edd0eac6
fix bug in fxview-tab-list.mjs r=fxview-reviewers,sclements

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/dc00edd0eac6

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Logan, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Donal Meehan [:dmeehan]]

3

Comment 7

[Logan Rosen [:Logan]]

sfoster, can you speak to the criticality of this/whether it needs an uplift?

Comment 8

[Sarah Clements [:sclements]]

We should try to get this uplifted to 120 Beta, since as I said in the patch there might be an edge case that affects this.

Comment 9

[Dianna Smith [:diannaS]]

adding NI for fx120 beta nomination

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9360134 [details]
Bug 1860931 - fix bug in fxview-tab-list.mjs r?#fxview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Recently-closed tabs items in firefox view might re-open into the wrong window, or not at all.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Close some tabs from a 2nd browser window, and view the recently-closed tabs list in firefox view. Clicking an item in this list should restore the tab to the originating window.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Single-line fix in code that only affects this particular component in firefox view.
• String changes made/needed: None
• Is Android affected?: No

Comment 11

[Sam Foster [:sfoster] (he/him)]

Thanks again for spotting this and putting in the patch :Logan

Comment 12

[Peter Magyari (Desktop QA)]

Hi,

I am trying to verify the fix following the steps from Comment 10 but after closing some tabs from a 2nd window and then restoring them in another window from the recently-closed tab list in Firefox view, still opens them in the current window not the originating one.

Am I missing something here?

Comment 13

[Sarah Clements [:sclements]]

(In reply to Peter Magyari (Desktop QA) from comment #12)

Hi,

I am trying to verify the fix following the steps from Comment 10 but after closing some tabs from a 2nd window and then restoring them in another window from the recently-closed tab list in Firefox view, still opens them in the current window not the originating one.

Am I missing something here?

I think this is in fact expected behavior for firefox view... I think sfoster got confused by what this was fixing? From what I can see, sourceWindowId is used in recently closed tabs to delete a closed tab when a user dismisses that entry in Firefox View per this code.

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9360134 [details]
Bug 1860931 - fix bug in fxview-tab-list.mjs r?#fxview-reviewers

Approved for 120.0b5

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0b63d0e29b2

Comment 16

[Peter Magyari (Desktop QA)]

Following up Comment 13, the sourceWindowId attribute of the tab row is now correctly assigned with one equal sign instead of two.
Dismissing a recently closed entry in Firefox View does still also remove it from recently closed tabs correctly.
Not sure how else I could verify the fix in this case.

Thank you for the clarification Sarah!