1858065 - Use packaging's Version instead of distutils' StrictVersion in mozbuild/nodeutil.py

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Description

[[:sergesanspaille]]

As of Python 3.12, distutils is no longer available, and using packaging's Version is the official recommandation, see https://github.com/pypa/packaging/issues/520

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1858065 - Replace distutils' StrictVersion r=saschanaz!

distutils have been removed from Python 3.12.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/561899ab9176
Use packaging's Version instead of distutils' StrictVersion r=saschanaz

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for breaking local mach browsertime tooling

backout link: https://hg.mozilla.org/integration/autoland/rev/b49831a88fee30aa339aec323a039628e4b9a9ef

Comment 4

[[:sergesanspaille]]

Change spotted, new revision pushed, waiting for saschana's approval

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

I just added a comment there.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee3b3779af7f
Replace distutils' StrictVersion r=saschanaz,perftest-reviewers,sparky

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ee3b3779af7f

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1858065 - Replace distutils' StrictVersion

distutils have been removed from Python 3.12, so replace it:

Sometimes using packaging's Version, sometimes providing our own in the
case of mozrelease/versions.py. Add more tests for the latter.

Original Revision: https://phabricator.services.mozilla.com/D190540

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/65685b318922