1743785 - [meta] distutils is deprecated, refactor usages

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

./mach build shows a warning when running on Python 3.10, and per searchfox I believe it's not only mach build. See also https://www.python.org/dev/peps/pep-0632/.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mhentges, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mhentges, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Those who need to parse the output of Mach output can hide Python warning output with the PYTHONWARNINGS environment variable.
E.g.:

PYTHONWARNINGS=ignore ./mach <command>

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

This is a great bug for future contributors!
We need to adjust all usages of distutils to be ported to something that's still maintained.
A couple notes:

• We don't need to port anything in third_party/python, or testing/web-platform/tests/tools/third_party
• There's some helpful distutils porting docs here
• Let's break down work here by component (mozbuild, mozrelease, mozperftest, etc), creating "sub-bugs" of this meta bug for each one.
• It looks like the majority of changes will be from distutils.version.LooseVersion to packaging.version.Version, and from distutils.spawn.find_executable to shutil.which

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

testing/web-platform/tests/tools/third_party

Still will be good to have 😉 (but https://github.com/web-platform-tests/wpt is the better place to do it I guess)

Comment 7

[Mitchell Hentges [:mhentges] 🦀]

Still will be good to have 😉

True, but those will be solved by updating those vendored dependencies - we shouldn't patch distutils out of them, because then we're soft-forking the 3rd-party code, which I don't think we want :)

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Things in WPT should be automatically synced back to the upstream by wpt-sync bot, so I think that shouldn't be problematic.

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Oh actually scratch that, it's third_party in WPT!

Comment 10

[Sean Feng [:sefeng211]]

Attachment: python3.12 diff

My mac just upgrade to python 3.12 and I had to manually make some addition changes to make `./mach mochitest` to work. 

```diff

```

Comment 11

[Sean Feng [:sefeng211]]

Attachment: python312.diff

(sorry, accidentally submitted the same comment twice)

Comment 12

[Alex Hochheiden [:ahochheiden]]

I think that as of bug 1929447, this is complete. All first-party usages of distutils have been removed/refactored. The only ones left are in third-party dependencies, which aren't in scope for this. If we need to update a third-party dependency to resolve a distutils issue it should be done in a separate bug.