Closed Bug 1858148 Opened 2 months ago Closed 1 month ago

Extend ESLint rule mozilla/reject-importGlobalProperties to reject imports in sjs files

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox121 fixed)

RESOLVED FIXED
Tracking Status
firefox121 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In bug 1858146, I am extending the sjs sandbox to include more of the global properties. The aim is to avoid needing to import any globals, as these are test files, and having more globals available shouldn't matter but make it easier for developers.

This bug is to completely prevent use of importGlobalProperties for sjs files, and suggest to extend the sjs sandbox list if any are missing.

Depends on: 1860830
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0621aeb4a210
Remove Cu.importGlobalProperties from sjs files as it is no longer needed. r=mossop,webdriver-reviewers,necko-reviewers,search-reviewers,devtools-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,dao,daleharvey,valentin
https://hg.mozilla.org/integration/autoland/rev/99e6cf5ab763
Change ESLint rule reject-importGlobalProperties to reject all imports in sjs files. r=mossop
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3265a9965e6c
Remove Cu.importGlobalProperties from Thunderbird .sjs files where it's no longer needed. r=eslint DONTBUILD
You need to log in before you can comment on or make changes to this bug.