Closed Bug 1858211 Opened 2 years ago Closed 2 years ago

Interop: Enable ARIAReflection flag to match WebKit and Chromium engines

Categories

(Core :: Disability Access APIs, defect)

Firefox 120
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: james, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.1 Safari/605.1.15

Steps to reproduce:

Expected the ARIA property reflection syntax to work:

el.ariaLabel = "foo";
el.getAttribute("aria-label"); // returns "foo"

Current WPT test file is here:
https://github.com/web-platform-tests/wpt/blob/master/html/dom/aria-element-reflection.html

Test run results currently:

  • Firefox 120
  • Linux 20.04
  • WPT 71600fa
  • Oct 10, 2023

Actual results:

It looks like this is only supported under a Gecko feature flag:

accessibility.ARIAReflection.enabled

To match the other engines that shipped this several years ago, consider removing the flag or enable by default.

Expected results:

Accessibility: WPT Interop tests for ARIA DOM properties should pass in Gecko to match the behavior in WebKit and Chromium.

https://wpt.fyi/results/html/dom/aria-element-reflection.html?label=master&label=experimental&aligned&q=label%3Aaccessibility

Or, if the Firefox accessibility team has issues with the spec as-is, which are they?

The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Disability Access APIs
Product: Firefox → Core

These DOM tests are currently part of the Interop 2024 Focus Area proposal so please comment there if there are blocking issues.

https://github.com/web-platform-tests/interop/issues/526

accessibility.ARIAReflection.enabled should be enabled by default in 119. See bug 1785412.

Perhaps this bug should be reused to track the Interop test failures?

(In reply to James Craig from comment #0)

Expected the ARIA property reflection syntax to work:

el.ariaLabel = "foo";
el.getAttribute("aria-label"); // returns "foo"

It does in 119+.

To match the other engines that shipped this several years ago, consider removing the flag or enable by default.

My understanding was that ARIA element reflection hadn't shipped in Chrome either. It's still behind a flag. I thought the same was true for Safari too, but I guess I'm wrong given that you filed this bug.

(In reply to James Craig from comment #5)

Interesting.... I wonder why the tests are still failing in 120.

The tests you linked are ARIA element reflection; i.e. ariaActiveDescendantElement, ariaLabelledByElements. We have only implemented (and now shipped) ARIA reflection for non-idref attributes; e.g. role, ariaLabel.

(In reply to James Craig from comment #1)

Or, if the Firefox accessibility team has issues with the spec as-is, which are they?

Our issues relate to crossing of shadow DOM boundaries. Some of this got resolved, but at the cost of being able to cross into darker shadow roots, which as I understand it was one of the primary use cases (if not the only real use case) for element reflection. Other solutions are being discussed to solve that problem, but that raises the question of whether element reflection is actually useful in its current state.

Oh course you’re right.

The non-element reflection tests I meant to link are passing, as expected.
https://wpt.fyi/results/html/dom/aria-attribute-reflection.html?label=experimental&label=master&aligned

Thanks. Okay to close this one.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.