1858305 - Computed variable can be added without parsing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Zach Hoffman [:zrhoffman]]

In bug 1846632, a new variable is created by parsing the CSS string of the properties_and_values::ComputedValue.

Because we already know that the string is valid CSS, we can skip parsing and create a variable by providing the first and last token, the CSS string, and no references.

Comment 1

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1858305 - Update cssparser r=#supply-chain-reviewers,#style

WIP status because https://github.com/servo/rust-cssparser/pull/369
is not reviewed or merged.

Comment 2

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1858305 - Rewrite use of deprecated function TokenSerializationType::nothing() r=fredw,zsun,#style

Depends on D193547

Comment 3

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1858305 - Store ComputedPropertyValue without parsing r=zsun,fredw,#style

Depends on D193548

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96d0600a10ad
Update cssparser r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/194d0db1a1cb
Rewrite use of deprecated function TokenSerializationType::nothing() r=firefox-style-system-reviewers,emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9fd21fa2333
Store ComputedPropertyValue without parsing r=firefox-style-system-reviewers,emilio

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/96d0600a10ad
https://hg.mozilla.org/mozilla-central/rev/194d0db1a1cb
https://hg.mozilla.org/mozilla-central/rev/a9fd21fa2333

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c83f9005e8
Fix supply-chain audits. a=bholley

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/82c83f9005e8