1846632 - [css-properties-values-api] Use canonical units for custom properties with font-independent values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Zach Hoffman [:zrhoffman]]

For "<length>", "<length-percentage>", "<angle>", "<time>", "<resolution>", "<integer>", "<number>", and "<percentage>" values:

• If the specified value is a dimension literal (such as 50em or .2s), the computed value is the same value, but with the unit converted to the corresponding canonical unit for the type of value.

• If the specified value is any other numeric literal (such as 5 or 20%), the computed value is as specified. (In particular, percentages are never resolved against anything.)

• If the specified value is a function that evaluates to one of those types (such as a math function), the computed value is defined by that function.

Comment 2

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1846632 - [css-properties-values-api] Store ComputedValue ToCss result r=fredw,zsun,#style,#layout

Other than making some computed <color> WPTs pass, this mostly does not
change behavior.

Depends on D190252

Comment 3

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1846632 - [css-properties-values-api] Use canonical values for font-independent types r=fredw,zsun,#style,#layout

We resolve calc expressions and use appropriate units by computing
ToComputedValue trait, computing each component's value, then converting
it back to that component's type, before making a new VariableValue from
the computed value's CSS string to store in the computed properties map.

Depends on D190253

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2df3706fe5c0
[css-properties-values-api] Store ComputedValue ToCss result r=fredw,emilio
https://hg.mozilla.org/integration/autoland/rev/2609670e6e11
[css-properties-values-api] Use canonical values for font-independent types r=fredw,emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2df3706fe5c0
https://hg.mozilla.org/mozilla-central/rev/2609670e6e11