1858349 - Submenu arrows missing on macOS

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Sam Johnson]

Attachment: Example of the issue

Submenus for anchored menus are missing on macOS after bug 1849793 (according to mozregression). Note that these are not native menus like context menus are (which render fine).

Attached is a screenshot of the "change your view" menu in the Library window (in dark mode, but this happens in both dark and light mode). Note that both "show columns" and "sort" should have a submenu arrow, but it is missing. The submenus still render as expected.

Comment 1

[Sam Johnson]

I accidentally a word above, it should read Submenu arrows for anchored menus are missing.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1849793, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1858349 - Use non-native menu arrows everywhere. r=#theme,#mac-reviewers

Our arrow is actually more similar to the modern macOS native ones, so
this both looks better and allows us to clean up more code.

flex-end alignment on acceltext-container is not needed (the flex item
is sized to its contents), removing it doesn't change behavior on e.g.
the menubar menus on Linux.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1858349 - Remove now-unused menuarrow code. r=spohl,#mac-reviewers

The windows bits were already unused.

Depends on D190663

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849793

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d28557bfe634
Use non-native menu arrows everywhere. r=desktop-theme-reviewers,dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56985665f52c
Fix whitespace nit pointed out after landing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dc6ef956702
Remove now-unused menuarrow code. r=spohl,mac-reviewers,win-reviewers,rkraesig

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d28557bfe634
https://hg.mozilla.org/mozilla-central/rev/56985665f52c

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0dc6ef956702

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9357800 [details]
Bug 1858349 - Use non-native menu arrows everywhere. r=#theme,#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0. Would be good to also test menus on Linux / windows.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple CSS change. I could provide a more minimal patch if needed tomorrow, but this is probably fine.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9357800 [details]
Bug 1858349 - Use non-native menu arrows everywhere. r=#theme,#mac-reviewers

Approved for 119.0b9

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/478de2106e0e
https://hg.mozilla.org/releases/mozilla-beta/rev/802d09e7b4d4

Comment 15

[Peter Magyari (Desktop QA)]

I have reproduced the issue on Firefox Nightly 120.0a1 (20231011092203) and verified the fix using Firefox Nightly 120.0a1 (20231013093747) and Firefox Beta 119.0b9 (20231013091412) on MacOS 11.6 and MacOS 12.3. I have also verified some menus on Ubuntu and Windows, no issues encountered.